-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): re-attempt fix #8
Conversation
The failing "Protobuf / break-check" workflow, in my opinion, should be ignored for this pull request because the changes are only cosmetic in nature (the Go code remains unchanged). However, do note that the JSON serialization of the objects will change because their JSON name has actually changed. Per my understanding, we do not use JSON serialization outside of the genesis file or the API or the CLI; so we should be good from a chain running perspective. The staking portal could need some changes. "Consensus Warn / main (pull_request_target)" runs on the base (default?) branch and thus will not succeed until the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If it is necessary to do so, the old JSON serialization can be retained with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since the JSON API change will not be immediately deployed to our nodes, I will send a draft PR to the staking portal to account for it. The deployment will have to be coordinated amongst the two. |
This is another attempt to fix all of the Github workflows for the
develop
branch. Since all of our PRs will merge to develop, the base branch must have its workflows passing successfully before our changes can have their code quality assessed.Noteworthy changes:
high
.proto
files have been linted and thego
files re-generated.