fix: skip cache commit when refill cache on node restart #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Test passed with commit ad78f76. |
cloud8little
approved these changes
May 10, 2024
MaxMustermann2
approved these changes
May 10, 2024
|
Please fix golang lint action error |
mikebraver
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when a node restart, it will refill the cache from persistent state. During this process, the
updateflag will be set in cache which cause the commit to update state by mistake(there's actually no update like validatorSet change).Changes
Notable changes:
SkipCommitforcache, used to skip the real commit by setting theupdateflag to falseIssue #51
Closes #XXX