refactor(assets): validator pubkey -> id

precompiles/assets/IAssets.sol

@@ -36,12 +36,12 @@ interface IAssets {
     /// @param clientChainID is the layerZero chainID if it is supported.
     //  It might be allocated by Exocore when the client chain isn't supported
     //  by layerZero
-    /// @param validatorPubkey The validator's pubkey
+    /// @param validatorID The validator's identifier (index or pubkey)
     /// @param stakerAddress The staker address
     /// @param opAmount The amount to deposit
     function depositNST(
         uint32 clientChainID,
-        bytes calldata validatorPubkey,
+        bytes calldata validatorID,
         bytes calldata stakerAddress,
         uint256 opAmount
     ) external returns (bool success, uint256 latestAssetState);
@@ -66,12 +66,12 @@ interface IAssets {
     /// @param clientChainID is the layerZero chainID if it is supported.
     //  It might be allocated by Exocore when the client chain isn't supported
     //  by layerZero
-    /// @param validatorPubkey The validator's pubkey
+    /// @param validatorID The validator's identifier (index or pubkey)
     /// @param withdrawAddress The withdraw address
     /// @param opAmount The withdraw amount
     function withdrawNST(
         uint32 clientChainID,
-        bytes calldata validatorPubkey,
+        bytes calldata validatorID,
         bytes calldata withdrawAddress,
         uint256 opAmount
     ) external returns (bool success, uint256 latestAssetState);

precompiles/assets/abi.json

@@ -50,7 +50,7 @@
       },
       {
         "internalType": "bytes",
-        "name": "validatorPubkey",
+        "name": "validatorID",
         "type": "bytes"
       },
       {
@@ -300,7 +300,7 @@
       },
       {
         "internalType": "bytes",
-        "name": "validatorPubkey",
+        "name": "validatorID",
         "type": "bytes"
       },
       {

precompiles/assets/tx.go

@@ -66,7 +66,7 @@ func (p Precompile) DepositOrWithdraw(
 			depositWithdrawParams.StakerAddress, depositWithdrawParams.AssetsAddress)
 		err = p.assetsKeeper.UpdateNSTValidatorListForStaker(ctx, assetID,
 			hexutil.Encode(depositWithdrawParams.StakerAddress),
-			hexutil.Encode(depositWithdrawParams.ValidatorPubkey),
+			hexutil.Encode(depositWithdrawParams.ValidatorID),
 			opAmount)
 		if err != nil {
 			return nil, err

precompiles/assets/types.go

@@ -63,14 +63,16 @@ func (p Precompile) DepositWithdrawParams(ctx sdk.Context, method *abi.Method, a
 			depositWithdrawParams.Action = assetstypes.WithdrawLST
 		}
 	case MethodDepositNST, MethodWithdrawNST:
-		validatorPubkey, ok := args[1].([]byte)
-		if !ok || len(validatorPubkey) == 0 {
+		validatorID, ok := args[1].([]byte)
+		// the length of the public key / identifier is not fixed. it depends on the source chain.
+		// for example, in Ethereum we have a uint256 == validator index but in Sui it is 96 bytes.
+		if !ok || len(validatorID) == 0 {
 			return nil, fmt.Errorf(exocmn.ErrContractInputParaOrType, 1, "[]byte", args[1])
 		}
 		// generate the virtual address for native restaking asset
 		depositWithdrawParams.AssetsAddress = assetstypes.GenerateNSTAddr(clientChainAddrLength)
 		// todo: add a check for the validator pubkey
-		depositWithdrawParams.ValidatorPubkey = validatorPubkey
+		depositWithdrawParams.ValidatorID = validatorID
 		if method.Name == MethodDepositNST {
 			depositWithdrawParams.Action = assetstypes.DepositNST
 		} else {

x/assets/keeper/bank.go

@@ -15,7 +15,7 @@ type DepositWithdrawParams struct {
 	AssetsAddress   []byte
 	StakerAddress   []byte
 	OpAmount        sdkmath.Int
-	ValidatorPubkey []byte
+	ValidatorID     []byte
 }
 
 // PerformDepositOrWithdraw the assets precompile contract will call this function to update asset state