appchain: e2e + CI testing #229
Conversation
x/avs handles the assetID validation
- Anyone can create a subchain via a simple transaction. The genesis file is available at the end of the current epoch. - If no operators opt in by that time, it is dropped. - If the state is available, it is queried via CLI and added to the genesis file of the subchain. - The genesis file, with data from other modules, starts the chain once enough vote power is live
The AVS module now validates the assetIDs passed to it
negative duration is also not supported
The wrapped consensus key object has utility in the subscriber module as well, and, may have some utility in the coordinator module. Hence, it is better located in a `types` subpackage.
even though it is done in Delegate as well, here is nicer
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| keys[authtypes.StoreKey], | ||
| authtypes.ProtoBaseAccount, | ||
| maccPerms, | ||
| sdk.Bech32PrefixAccAddr, |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
| for acc := range maccPerms { | ||
| modAccAddrs[authtypes.NewModuleAddress(acc).String()] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for key, val := range defaults { | ||
| set(c.Flags(), key, val) | ||
| set(c.PersistentFlags(), key, val) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, update := range m { | ||
| out = append(out, update) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
|
|
||
| import ( | ||
| context "context" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
| if err != nil { | ||
| // It is the common behavior in cosmos-sdk to panic if SendCoinsFromModuleToModule | ||
| // returns error. | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| if err != nil { | ||
| // This should never happen as the pubkey is assumed | ||
| // to be stored correctly in ApplyCCValidatorChanges. | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| if err != nil { | ||
| // This should never happen as the pubkey is assumed | ||
| // to be stored correctly in ApplyCCValidatorChanges. | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| "height", height, "vscID", vscID, | ||
| ) | ||
|
|
||
| am.keeper.TrackHistoricalInfo(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| } | ||
|
|
||
| // EndBlock contains the logic that is automatically triggered at the end of each block | ||
| func (am AppModule) EndBlock(ctx sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate { | ||
| return am.keeper.EndBlock(ctx) | ||
| // send rewards to coordinator | ||
| am.keeper.EndBlockSendRewards(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
- Run `./local_node.sh` - Run `./app/subscriber/script.sh` Wait for `subscriberd` to start producing blocks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
DRAFT