feat(appchain): add unit tests #225

MaxMustermann2 · 2024-10-22T04:24:46Z

Includes #176 and #187

x/avs handles the assetID validation

- Anyone can create a subchain via a simple transaction. The genesis file is available at the end of the current epoch. - If no operators opt in by that time, it is dropped. - If the state is available, it is queried via CLI and added to the genesis file of the subchain. - The genesis file, with data from other modules, starts the chain once enough vote power is live

The AVS module now validates the assetIDs passed to it

negative duration is also not supported

The wrapped consensus key object has utility in the subscriber module as well, and, may have some utility in the coordinator module. Hence, it is better located in a `types` subpackage.

* fix: use NST instead of LST * fix: use len==0 to include both nil and empty []byte * test: add precompile test for NST

ExocoreNetwork#208) * add rest api to query token-index, update price-feeder to panic at error initialization * lint

* fix: update cache when assetID updated in params * fix:update params with latest params when do recache * remove debug log

…oreNetwork#207) * detail the return error for operator info * adjust the error handling in beginBlock and endBlock * rebase and fix the conflict

)

* remove useless and unsafe precompilation methods * add some coments for avs * fix unnecessary iterations * removing submitProof functionalities * fix precompile args check * fix non zero-based sequential constants

* detail the return error for operator info * add a cli to query the opted info for specified operator and avs * remove the redundant code regarding the command line of operator module * add parameter for url of the google api when defining RPC * check the AVS address and convert it to lower case in the command line

* fix: RTE-01 * fix: GWT-01 * refactor: optimize shared code * fix: ENO-01 * fix(test): fix the claim reward test * fix: validate auth addr as bech32 * fix(feedistr): add authority validation

TODO: rewards_test.go is still failing

utils/utils.go

+	for _, update := range m {
+		out = append(out, update)
+	}


x/appchain/common/types/expected_keepers_mocks.go

+
+import (
+	context "context"
+	reflect "reflect"


x/appchain/coordinator/types/expected_keepers_mocks.go

+package types
+
+import (
+	reflect "reflect"


x/appchain/subscriber/keeper/rewards.go

+	frac, err := sdk.NewDecFromStr(k.GetSubscriberParams(ctx).SubscriberRedistributionFraction)
+	if err != nil {
+		// should not happen since we validated this in the params
+		panic(err)


x/appchain/subscriber/keeper/rewards.go

+	if err != nil {
+		// It is the common behavior in cosmos-sdk to panic if SendCoinsFromModuleToModule
+		// returns error.
+		panic(err)


x/appchain/subscriber/keeper/rewards.go

+	if err != nil {
+		// It is the common behavior in cosmos-sdk to panic if SendCoinsFromModuleToModule
+		// returns error.
+		panic(err)


x/appchain/subscriber/keeper/validators.go

+		if err != nil {
+			// This should never happen as the pubkey is assumed
+			// to be stored correctly in ApplyCCValidatorChanges.
+			panic(err)


x/appchain/subscriber/keeper/validators.go

+		if err != nil {
+			// This should never happen as the pubkey is assumed
+			// to be stored correctly in ApplyCCValidatorChanges.
+			panic(err)


x/appchain/subscriber/module.go

+		"height", height, "vscID", vscID,
+	)
+
+	am.keeper.TrackHistoricalInfo(ctx)


x/appchain/subscriber/module.go

 }

 // EndBlock contains the logic that is automatically triggered at the end of each block
 func (am AppModule) EndBlock(ctx sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate {
-	return am.keeper.EndBlock(ctx)
+	// send rewards to coordinator
+	am.keeper.EndBlockSendRewards(ctx)


coderabbitai · 2024-10-28T14:40:22Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-13T00:11:30Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

MaxMustermann2 added 30 commits August 25, 2024 14:19

feat(appchain): scaffold coordinator

53177cf

feat(appchain): scaffold subscriber

8ee1253

feat(epochs): create number + id structure

a1158d5

feat(appchain): add coordinator params

7c1922a

fix(epochs): invalidate negative duration

f1bca4d

fix(avs): stateful validation of staking assets

9f9e994

refactor(dogfood): carve sortByPower out

0e1cd06

fix(dogfood): avoid duplicate validation

9073b71

x/avs handles the assetID validation

fix(dogfood): replace with max unbonding duration

e06c529

doc(app): add comment about slashing frac storage

04e0d67

chore(lint)

4bd8948

Merge develop

13e6a72

fix(test): make avs test pass

571c65e

The AVS module now validates the assetIDs passed to it

fix(appchain): remove superfluous test

6f4cfa0

fix(epochs): update expected test message

19ce74a

negative duration is also not supported

chore(lint)

0a0688c

chore(lint): proto lint

6cb92fc

chore: run proto gen

ca8b2ee

fix(appchain): remove floating point arithmetic

cfba037

fix(appchain): remove wrong comment

013f938

doc(appchain): add comment about params expect

dc7915d

fix(appchain): remove superfluous fmt

607e12e

feat(appchain): report invalid json

4a275d3

fix(utils): remove SliceStable and use Slice

e9d8fc0

doc(appchain): add more logging

3be6882

chore(lint)

4401e3f

fix(ci): pin the golang lint version

47714fc

chore(lint): remove unused timestamp proto

2904a40

refactor(dogfood,operator): carve out wrapped key

8d0db6c

The wrapped consensus key object has utility in the subscriber module as well, and, may have some utility in the coordinator module. Hence, it is better located in a `types` subpackage.

MaxMustermann2 and others added 13 commits October 18, 2024 10:17

app: introduce coordinator module

8e931aa

Merge develop

7ecbfbf

app: introduce coordinator module

ccacb00

fix: use NST instead of LST (ExocoreNetwork#213)

dd31488

* fix: use NST instead of LST * fix: use len==0 to include both nil and empty []byte * test: add precompile test for NST

add rest api to query token-index, update price-feeder to panic at er… (

0ba5f43

ExocoreNetwork#208) * add rest api to query token-index, update price-feeder to panic at error initialization * lint

fix: update cache when assetID updated in params (ExocoreNetwork#214)

14a69e5

* fix: update cache when assetID updated in params * fix:update params with latest params when do recache * remove debug log

fix(abci): adjust the error handling in beginBlock and endBlock (Exoc…

75b6b09

…oreNetwork#207) * detail the return error for operator info * adjust the error handling in beginBlock and endBlock * rebase and fix the conflict

add oracle_env_beaconchain yaml config in local_node (ExocoreNetwork#215

5b55dab

)

fix(audit): Fix audit issues (ExocoreNetwork#188)

1cc8dfb

* remove useless and unsafe precompilation methods * add some coments for avs * fix unnecessary iterations * removing submitProof functionalities * fix precompile args check * fix non zero-based sequential constants

fix(audit): resolve more audit findings (ExocoreNetwork#217)

875ab5a

* fix: RTE-01 * fix: GWT-01 * refactor: optimize shared code * fix: ENO-01 * fix(test): fix the claim reward test * fix: validate auth addr as bech32 * fix(feedistr): add authority validation

tests(coordinator): add unit tests

9ae4d76

test(subscriber): add subscriber unit tests

b317602

TODO: rewards_test.go is still failing

github-actions bot added C:Proto C:CLI labels Oct 22, 2024

MaxMustermann2 added 2 commits October 22, 2024 06:42

fix(test): fix the reward unit test

7e167be

Merge develop into this branch

c0a5c0b

github-actions bot removed the C:CLI label Oct 22, 2024

github-advanced-security bot found potential problems Oct 22, 2024

View reviewed changes

MaxMustermann2 added 7 commits October 22, 2024 07:32

fix(app): add module correctly

c59c3e2

Merge branch 'appchains-pt3' into appchains-pt4

6d05c8b

refactor: rename function param for clarity

cfca848

refactor: rename object for clarity

0ca361d

Merge develop

f9554f2

Merge branch 'appchains-pt2' into appchains-pt3

e7a6165

Merge branch 'appchains-pt3' into appchains-pt4

4243cd8

github-actions bot added the Status: Stale label Dec 13, 2024

github-actions bot closed this Dec 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(appchain): add unit tests #225

feat(appchain): add unit tests #225

MaxMustermann2 commented Oct 22, 2024

coderabbitai bot commented Oct 28, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Dec 13, 2024

feat(appchain): add unit tests #225

feat(appchain): add unit tests #225

Conversation

MaxMustermann2 commented Oct 22, 2024

coderabbitai bot commented Oct 28, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Dec 13, 2024

coderabbitai bot commented Oct 28, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)