fix(assets): allow native chain to be registered

[MaxMustermann2]

• LayerZero ID of 0 supported for native chain
• IsRegisteredClientChain explicitly returns false to prevent cross-chain messaging
• Adding more native tokens or modifying the existing ones is allowed

Summary by CodeRabbit

• New Features

  • Introduced a conditional check for unregistered client chains, enhancing error handling for clientChainID of 0.

• Bug Fixes

  • Removed outdated validation for LayerZeroChainID in the GenesisState, streamlining the client chain validation process.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a conditional check in the IsRegisteredClientChain method to handle a clientChainID of zero distinctly, preventing further processing if this condition is met. Additionally, a validation step for a non-zero LayerZeroChainID has been removed from the ValidateClientChains method, altering the validation logic for the GenesisState struct.

Changes

File	Change Summary
precompiles/assets/tx.go	Updated IsRegisteredClientChain method to check if clientChainID is zero, returning a specific output and preventing further processing if true.
x/assets/types/genesis.go	Removed validation for a non-zero LayerZeroChainID in the ValidateClientChains method, simplifying the validation logic while retaining address length checks.

Poem

In the meadow where changes bloom,
A rabbit hops with joy, dispelling gloom.
With checks in place, and validations gone,
We dance through code, from dusk till dawn.
Hooray for logic, clear and bright,
A happy hop in the coding light! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MaxMustermann2]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

precompiles/assets/tx.go (1)

219-222: Suggest adding a more detailed comment for clarity.

While the code change is correct, it would be beneficial to add a more detailed comment explaining the rationale behind the special handling of clientChainID 0. This would improve code maintainability and make the intention clearer for future developers.

Consider adding a comment like this:

// Special handling for clientChainID 0 (native chain)
// We return false to prevent setPeer calls, ensuring that
// cross-chain messaging is not allowed for the native chain
// while still allowing it to be registered.
if clientChainID == 0 {
    return method.Outputs.Pack(true, false)
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 70c8691 and e50aacb.

📒 Files selected for processing (2)

• precompiles/assets/tx.go (1 hunks)
• x/assets/types/genesis.go (0 hunks)

💤 Files not reviewed due to no reviewable changes (1)

• x/assets/types/genesis.go

🔇 Additional comments (1)

precompiles/assets/tx.go (1)

219-222: LGTM! Changes align with PR objectives.

The new condition for clientChainID == 0 successfully implements the requirement to allow native chain registration while preventing cross-chain messaging for the native chain. This change maintains the integrity of the existing functionality for non-zero clientChainID values.