chore(lint): Fix super linter (again) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a variable name contains the word KEY, gitleaks does not like it and flags it as a potential secret. I have changed the name of the variable in these files from KEYALGO to ALGO since it is not a secret but rather the algorithm of the key generation. That silences gitleaks.
added a blank line at the end of `.golangci.yml`
The previous commit worked on the markdownlint from the super-linter.
The OS keyring may not always be available.
It can potentially reduce the number of layers in the image, making it smaller and more efficient to build and pull.
Note that this file is used from the root of the project via `make localnet-build`, which is why the paths work.
MaxMustermann2
force-pushed
the
fix/super-linter-v2
branch
2 times, most recently
from
e2493e2 to
a36167d
Compare
MaxMustermann2
force-pushed
the
fix/super-linter-v2
branch
from
a36167d to
72b459a
Compare
|
On the Of these, the failures are On this pull request, the items that run are as follows. All of these passed, including the ones that previously failed on Note that the JSON check is not run within this PR, but it was run on The PR adds back the IaC (Infrastructure as Code) check and ensures it passes and skips generated files.
|
MaxMustermann2
requested review from
rlan35,
adu-web3,
mikebraver and
TimmyExogenous
CVE-2024-24786 / GO-2024-2611 is fixed with this upgrade. Even though this package is fundamental to our system, the changes between 1.31.0 and 1.33.0 are minor.
This reverts commit c09f986.
A vulnerability has been fixed in v1.33.0 of google.golang.org/protobuf and we must update the associated github.com/golang/protobuf as well.
|
Files which have noteworthy changes to review:
|
The test workflow will not fully run right now because it runs on `pull_request_target` which must be merged into the base branch first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The super linter workflow is running differently between a branch push and a pull request. As a consequence, we see a failure on the branch here when a run on the corresponding pull request passed. This change attempts to fix the issue.