fix: use blank slash contract not 0x0000

ExocoreNetwork · Oct 29, 2024 · 4bbf229 · 4bbf229
1 parent d84a457
commit 4bbf229
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/precompiles/avs/utils_test.go b/precompiles/avs/utils_test.go
@@ -150,7 +150,6 @@ func (suite *AVSManagerPrecompileSuite) TestOptIn() {
 	usdValue := operatorKeeper.CalculateUSDValue(suite.delegationAmount, price.Value, suite.assetDecimal, price.Decimal)
 	expectedState := &StateForCheck{
 		OptedInfo: &operatorTypes.OptedInfo{
-			SlashContract:  "0x0000000000000000000000000000000000000000",
 			OptedInHeight:  uint64(suite.Ctx.BlockHeight()),
 			OptedOutHeight: operatorTypes.DefaultOptedOutHeight,
 		},
@@ -200,7 +199,6 @@ func (suite *AVSManagerPrecompileSuite) TestOptOut() {
 
 	expectedState := &StateForCheck{
 		OptedInfo: &operatorTypes.OptedInfo{
-			SlashContract:  "0x0000000000000000000000000000000000000000",
 			OptedInHeight:  uint64(optInHeight),
 			OptedOutHeight: uint64(suite.Ctx.BlockHeight()),
 		},

diff --git a/x/avs/keeper/avs.go b/x/avs/keeper/avs.go
@@ -46,7 +46,9 @@ func (k *Keeper) GetAVSSlashContract(ctx sdk.Context, avsAddr string) (string, e
 	if err != nil {
 		return "", errorsmod.Wrap(err, fmt.Sprintf("GetAVSSlashContract: key is %s", avsAddr))
 	}
-
+	if avsInfo.Info.SlashAddr == (common.Address{}).String() {
+		return "", nil
+	}
 	return avsInfo.Info.SlashAddr, nil
 }
 

diff --git a/x/operator/keeper/opt_test.go b/x/operator/keeper/opt_test.go
@@ -141,7 +141,6 @@ func (suite *OperatorTestSuite) TestOptIn() {
 		OptedInfo: &operatorTypes.OptedInfo{
 			OptedInHeight:  uint64(suite.Ctx.BlockHeight()),
 			OptedOutHeight: operatorTypes.DefaultOptedOutHeight,
-			SlashContract:  common.Address{}.String(),
 		},
 		AVSTotalShare:    usdValue,
 		AVSOperatorShare: usdValue,
@@ -191,7 +190,6 @@ func (suite *OperatorTestSuite) TestOptOut() {
 		OptedInfo: &operatorTypes.OptedInfo{
 			OptedInHeight:  uint64(optInHeight),
 			OptedOutHeight: uint64(suite.Ctx.BlockHeight()),
-			SlashContract:  common.Address{}.String(),
 		},
 		AVSTotalShare:    sdkmath.LegacyNewDec(0),
 		AVSOperatorShare: sdkmath.LegacyNewDec(0),

diff --git a/x/operator/keeper/slash.go b/x/operator/keeper/slash.go
@@ -5,7 +5,6 @@ import (
 
 	"github.com/ExocoreNetwork/exocore/utils"
 	stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
-	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/common/hexutil"
 
 	errorsmod "cosmossdk.io/errors"
@@ -203,7 +202,6 @@ func (k Keeper) SlashWithInfractionReason(
 		SlashID:          slashID,
 		SlashEventHeight: infractionHeight,
 		SlashProportion:  slashFactor,
-		SlashContract:    common.Address{}.String(),
 	}
 	err := k.Slash(ctx, slashParam)
 	if err != nil {