refactor: remove isActivatedAtEpoch check for ExoCapsule.verifyDepositProof
#62
Conversation
|
Warning Rate limit exceeded@adu-web3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 11 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes streamline the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/core/ExoCapsule.sol (1 hunks)
- test/foundry/unit/ExoCapsule.t.sol (2 hunks)
Additional comments not posted (2)
src/core/ExoCapsule.sol (1)
Line range hint
98-99:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
verifyDepositProofare correctly updated to reflect the removal of theisActivatedAtEpochcheck.Verification successful
No issues found with the removal of the
isActivatedAtEpochcheck.
- The
verifyDepositProoffunction and its usage have been verified.- No dependencies on the removed
isActivatedAtEpochcheck were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `verifyDepositProof` are correctly updated. # Test: Search for the function usage. Expect: No references to the removed `isActivatedAtEpoch` check. rg --type solidity -A 5 $'verifyDepositProof'Length of output: 77
Script:
#!/bin/bash # Description: Verify all function calls to `verifyDepositProof` are correctly updated. # Find all Solidity files and search for the function usage within them. fd -e sol -x rg 'verifyDepositProof' {}Length of output: 1637
Script:
#!/bin/bash # Description: Verify that there are no dependencies on the removed `isActivatedAtEpoch` check. # Find all Solidity files and search for references to `isActivatedAtEpoch` within them. fd -e sol -x rg 'isActivatedAtEpoch' {}Length of output: 134
Script:
#!/bin/bash # Description: Verify that `_isActivatedAtEpoch` is not called in a way that impacts the removed check. # Find all Solidity files and search for calls to `_isActivatedAtEpoch` within them. fd -e sol -x rg '_isActivatedAtEpoch' {}Length of output: 135
test/foundry/unit/ExoCapsule.t.sol (1)
Line range hint
224-247:
LGTM!The changes to the test function
test_verifyDepositProof_success_inactiveValidatorContaineralign with the updated contract behavior and ensure that the function executes successfully without theisActivatedAtEpochcheck.
adu-web3
requested review from
bwhour,
wewecalibrate,
cloud8little,
MaxMustermann2 and
mikebraver
…ositProof` (ExocoreNetwork#62) * refactor: remove isActivated check * refactor: remove isActivatedAtEpoch check for verifyDepositProof * remove input.json * remove _isActivatedAtEpoch
Description
closes: #49
As long as the withdrawal_credentials of beacon chain validator points to the address of ExoCapsule, we could always take the validator's staked ETH into custody, so there is no need to require that validator must be activated when the proof is generated
Summary by CodeRabbit