Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable forge test github action by revise workflow file #15

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

adu-web3
Copy link
Collaborator

@adu-web3 adu-web3 commented Jun 3, 2024

Description

action that runs forge test against committed code of pull request is not enabled. we could revise exisiting test.yml file to activate it

according to my test in my personal repo, this should work: https://github.com/adu-web3/exocore-contracts/actions/runs/9346017944/job/25719994787?pr=2

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow triggers to run on pull requests and pushes to specific branches and tags.
    • Changed Foundry installation version from nightly to stable to avoid test failures.
    • Added a step to automatically comment on pull requests when the GitHub Actions workflow fails.

Copy link
Contributor

coderabbitai bot commented Jun 3, 2024

Warning

Rate limit exceeded

@adu-web3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 57 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 541b379 and c16162f.

Walkthrough

The .github/workflows/test.yml file has been updated to refine workflow triggers and ensure stability in Foundry installation. The workflow now triggers on pull requests, pushes to specific branches, and tags, switching Foundry from a nightly release to a stable version. Additionally, a step has been added to comment on GitHub issues if the workflow fails.

Changes

Files Change Summary
.github/workflows/test.yml Updated workflow triggers, changed Foundry version to stable, and added a failure comment step.

Poem

In the land of code where workflows reside,
Triggers now dance with branches wide.
Foundry stands stable, no nightly fright,
And failures whisper comments in the night.
A rabbit's joy, in changes bright,
Our code's adventure, set to new heights!
🌟🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fc15a0f and 85cb117.

Files selected for processing (1)
  • .github/workflows/test.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/test.yml (2)

3-10: Workflow triggers updated to include pull_request, push to main and release/** branches, and all tags.

This change ensures that the tests are run on a broader range of events, which is beneficial for continuous integration.


30-32: Foundry installation version pinned to a specific nightly release.

Pinning the version to nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9 is a prudent choice to avoid instability from breaking changes in newer releases. Consider documenting in the workflow file why this specific version was chosen for future reference.

Copy link
Collaborator

@bwhour bwhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 85cb117 and 541b379.

Files selected for processing (1)
  • .github/workflows/test.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test.yml

@adu-web3 adu-web3 force-pushed the forge-test-workflow branch from ad3f411 to 541b379 Compare June 3, 2024 08:18
@adu-web3 adu-web3 merged commit e57bf41 into ExocoreNetwork:main Jun 3, 2024
1 check passed
@adu-web3 adu-web3 deleted the forge-test-workflow branch June 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants