-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enable forge test github action by revise workflow file #15
Conversation
Warning Rate limit exceeded@adu-web3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 57 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/test.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/test.yml (2)
3-10
: Workflow triggers updated to includepull_request
,push
tomain
andrelease/**
branches, and all tags.This change ensures that the tests are run on a broader range of events, which is beneficial for continuous integration.
30-32
: Foundry installation version pinned to a specific nightly release.Pinning the version to
nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9
is a prudent choice to avoid instability from breaking changes in newer releases. Consider documenting in the workflow file why this specific version was chosen for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/test.yml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/test.yml
ad3f411
to
541b379
Compare
Description
action that runs
forge test
against committed code of pull request is not enabled. we could revise exisiting test.yml file to activate itaccording to my test in my personal repo, this should work: https://github.com/adu-web3/exocore-contracts/actions/runs/9346017944/job/25719994787?pr=2
Summary by CodeRabbit