Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generate): support native asset #103

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

MaxMustermann2
Copy link
Collaborator

@MaxMustermann2 MaxMustermann2 commented Sep 27, 2024

Add the native chain and native asset to x/assets and x/dogfood parameters

Summary by CodeRabbit

  • New Features

    • Introduced support for the Exocore blockchain and its native EXO token.
    • Enhanced the genesis file structure to include details about the new blockchain and token.
  • Bug Fixes

    • Improved the integration process for the genesis file updates.

Copy link
Contributor

coderabbitai bot commented Sep 27, 2024

Walkthrough

The changes introduce two new constants, nativeChain and nativeAsset, defining the Exocore blockchain and its native EXO token. Modifications to the updateGenesisFile function allow the integration of these constants into the genesisJSON structure, specifically appending them to the client_chains and tokens arrays, along with creating a new entry in the asset_ids array. This enhances the genesis file structure to accommodate the new blockchain and its asset.

Changes

File Change Summary
script/generate.js Added constants nativeChain and nativeAsset, modified updateGenesisFile to include these in genesisJSON.

Possibly related PRs

Suggested reviewers

  • cloud8little
  • trestinlsd
  • bwhour
  • leonz789
  • mikebraver

Poem

In the land of code where rabbits play,
New chains and tokens hop into the fray.
With genesis files, they dance and twirl,
A blockchain bloom in a digital whirl.
So let’s cheer for EXO, our shiny new friend,
In the world of tech, may the fun never end! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
script/generate.js (1)

683-683: Reminder: Address the TODO Comment Regarding Staking Data

The TODO comment at line 683 indicates that staking data should be copied over from the previous genesis file if available. This is important to maintain staking continuity and ensure that stakeholders' data is preserved. Please implement this functionality to complete the feature.

Would you like assistance in implementing this, or should I open a GitHub issue to track this task?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9c62433 and ebed2e0.

📒 Files selected for processing (1)
  • script/generate.js (2 hunks)

script/generate.js Show resolved Hide resolved
@cloud8little cloud8little added this pull request to the merge queue Sep 30, 2024
Merged via the queue into ExocoreNetwork:main with commit c976212 Sep 30, 2024
7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants