fix: use calldata for unmodified parameter

ExocoreNetwork · Aug 27, 2024 · d2bbefb · d2bbefb
1 parent e243963
commit d2bbefb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/core/ClientChainGateway.sol b/src/core/ClientChainGateway.sol
@@ -115,7 +115,7 @@ contract ClientChainGateway is
     }
 
     /// @inheritdoc IClientChainGateway
-    function quote(bytes memory _message) public view returns (uint256 nativeFee) {
+    function quote(bytes calldata _message) public view returns (uint256 nativeFee) {
         bytes memory options = OptionsBuilder.newOptions().addExecutorLzReceiveOption(
             DESTINATION_GAS_LIMIT, DESTINATION_MSG_VALUE
         ).addExecutorOrderedExecutionOption();

diff --git a/src/core/CustomProxyAdmin.sol b/src/core/CustomProxyAdmin.sol
@@ -32,7 +32,7 @@ contract CustomProxyAdmin is Initializable, ProxyAdmin {
     /// @param implementation The address of the new implementation contract.
     /// @param data The data to be passed to the new implementation contract.
     /// @dev This function can only be called by the proxy to upgrade itself, exactly once.
-    function changeImplementation(address proxy, address implementation, bytes memory data) public virtual {
+    function changeImplementation(address proxy, address implementation, bytes calldata data) public virtual {
         if (msg.sender != bootstrapper) {
             revert Errors.CustomProxyAdminOnlyCalledFromBootstrapper();
         }

diff --git a/src/core/ExocoreGateway.sol b/src/core/ExocoreGateway.sol
@@ -606,7 +606,7 @@ contract ExocoreGateway is
     }
 
     /// @inheritdoc IExocoreGateway
-    function quote(uint32 srcChainid, bytes memory _message) public view returns (uint256 nativeFee) {
+    function quote(uint32 srcChainid, bytes calldata _message) public view returns (uint256 nativeFee) {
         bytes memory options = OptionsBuilder.newOptions().addExecutorLzReceiveOption(
             DESTINATION_GAS_LIMIT, DESTINATION_MSG_VALUE
         ).addExecutorOrderedExecutionOption();