test: update test for deposit-then-delegate

Ensure that user is actually charged
ExocoreNetwork · Jun 13, 2024 · 2786ef2 · 2786ef2
1 parent 088ab83
commit 2786ef2
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 10 deletions.
diff --git a/test/foundry/DepositThenDelegateTo.t.sol b/test/foundry/DepositThenDelegateTo.t.sol
@@ -5,11 +5,13 @@ import "../../src/core/ExocoreGateway.sol";
 import "../../src/interfaces/precompiles/IDelegation.sol";
 import "../../src/storage/GatewayStorage.sol";
 import "../mocks/DelegationMock.sol";
+import {DepositMock} from "../mocks/DepositMock.sol";
 import "./ExocoreDeployer.t.sol";
 
 import {OptionsBuilder} from "@layerzero-v2/oapp/contracts/oapp/libs/OptionsBuilder.sol";
 import "@layerzero-v2/protocol/contracts/libs/AddressCast.sol";
 import "@layerzerolabs/lz-evm-protocol-v2/contracts/libs/GUID.sol";
+import {IERC20} from "@openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";
 import "forge-std/Test.sol";
 
 import "forge-std/console.sol";
@@ -52,6 +54,16 @@ contract DepositThenDelegateToTest is ExocoreDeployer {
         uint64 lzNonce = 1;
         uint256 delegateAmount = 10_000;
 
+        // ensure there is enough balance
+        vm.startPrank(exocoreValidatorSet.addr);
+        restakeToken.transfer(delegator, delegateAmount);
+        vm.stopPrank();
+
+        // approve it
+        vm.startPrank(delegator);
+        restakeToken.approve(address(vault), delegateAmount);
+        vm.stopPrank();
+
         (bytes32 requestId, bytes memory requestPayload) =
             _testRequest(delegator, operatorAddress, lzNonce, delegateAmount);
         _testResponse(requestId, requestPayload, delegator, relayer, operatorAddress, lzNonce, delegateAmount);
@@ -61,6 +73,8 @@ contract DepositThenDelegateToTest is ExocoreDeployer {
         private
         returns (bytes32 requestId, bytes memory requestPayload)
     {
+        uint256 beforeBalance = restakeToken.balanceOf(delegator);
+
         requestPayload = abi.encodePacked(
             GatewayStorage.Action.REQUEST_DEPOSIT_THEN_DELEGATE_TO,
             abi.encodePacked(bytes32(bytes20(address(restakeToken)))),
@@ -71,6 +85,9 @@ contract DepositThenDelegateToTest is ExocoreDeployer {
         uint256 requestNativeFee = clientGateway.quote(requestPayload);
         requestId = generateUID(lzNonce, true);
 
+        vm.expectEmit(address(restakeToken));
+        emit IERC20.Transfer(delegator, address(vault), delegateAmount);
+
         vm.expectEmit(address(clientChainLzEndpoint));
         emit NewPacket(
             exocoreChainId, address(clientGateway), address(exocoreGateway).toBytes32(), lzNonce, requestPayload
@@ -84,6 +101,10 @@ contract DepositThenDelegateToTest is ExocoreDeployer {
             address(restakeToken), delegateAmount, operatorAddress
         );
         vm.stopPrank();
+
+        // check that the balance changed
+        uint256 afterBalance = restakeToken.balanceOf(delegator);
+        assertEq(afterBalance, beforeBalance - delegateAmount);
     }
 
     // even though this function is called _testResponse, it also tests
@@ -101,15 +122,15 @@ contract DepositThenDelegateToTest is ExocoreDeployer {
         uint256 responseNativeFee = exocoreGateway.quote(clientChainId, responsePayload);
         bytes32 responseId = generateUID(lzNonce, false);
 
-        // vm.expectEmit(DELEGATION_PRECOMPILE_ADDRESS);
-        // emit DelegateRequestProcessed(
-        //     clientChainId,
-        //     lzNonce,
-        //     abi.encodePacked(bytes32(bytes20(address(restakeToken)))),
-        //     abi.encodePacked(bytes32(bytes20(delegator))),
-        //     operatorAddress,
-        //     delegateAmount
-        // );
+        vm.expectEmit(DELEGATION_PRECOMPILE_ADDRESS);
+        emit DelegateRequestProcessed(
+            clientChainId,
+            lzNonce,
+            abi.encodePacked(bytes32(bytes20(address(restakeToken)))),
+            abi.encodePacked(bytes32(bytes20(delegator))),
+            operatorAddress,
+            delegateAmount
+        );
 
         vm.expectEmit(true, true, true, true, address(exocoreLzEndpoint));
         // nothing indexed here
@@ -134,6 +155,16 @@ contract DepositThenDelegateToTest is ExocoreDeployer {
         );
         vm.stopPrank();
 
+        uint256 actualDepositAmount = DepositMock(DEPOSIT_PRECOMPILE_ADDRESS).principleBalances(
+            clientChainId,
+            // weirdly, the address(x).toBytes32() did not work here.
+            // that is because abi.encodePacked tightly packs the input
+            // and removes all zeroes.
+            abi.encodePacked(bytes32(bytes20(address(restakeToken)))),
+            abi.encodePacked(bytes32(bytes20(delegator)))
+        );
+        assertEq(actualDepositAmount, delegateAmount);
+
         uint256 actualDelegateAmount = DelegationMock(DELEGATION_PRECOMPILE_ADDRESS).getDelegateAmount(
             delegator, operatorAddress, clientChainId, address(restakeToken)
         );

diff --git a/test/mocks/DepositMock.sol b/test/mocks/DepositMock.sol
@@ -6,7 +6,7 @@ import "./WithdrawPrincipleMock.sol";
 
 contract DepositMock is IDeposit {
 
-    mapping(uint32 => mapping(bytes => mapping(bytes => uint256))) principleBalances;
+    mapping(uint32 => mapping(bytes => mapping(bytes => uint256))) public principleBalances;
 
     function depositTo(uint32 clientChainLzId, bytes memory assetsAddress, bytes memory stakerAddress, uint256 opAmount)
         external
@@ -29,6 +29,7 @@ contract DepositMock is IDeposit {
     ) external returns (bool success, uint256 latestAssetState) {
         require(opAmount <= principleBalances[clientChainLzId][assetsAddress][withdrawer], "withdraw amount overflow");
         principleBalances[clientChainLzId][assetsAddress][withdrawer] -= opAmount;
+        return (true, principleBalances[clientChainLzId][assetsAddress][withdrawer]);
     }
 
 }