fix: validate cons key non-empty

ExocoreNetwork · Aug 5, 2024 · 233acbb · 233acbb
1 parent 3eb235a
commit 233acbb
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/core/Bootstrap.sol b/src/core/Bootstrap.sol
@@ -222,6 +222,10 @@ contract Bootstrap is
         if (bytes(validators[validatorAddress].name).length > 0) {
             revert Errors.BootstrapValidatorAlreadyRegistered();
         }
+        // check that the consensus key is not empty.
+        if (consensusPublicKey == bytes32(0)) {
+            revert Errors.ZeroValue();
+        }
         // check that the consensus key is unique.
         if (consensusPublicKeyInUse[consensusPublicKey]) {
             revert Errors.BootstrapConsensusPubkeyAlreadyUsed(consensusPublicKey);
@@ -261,6 +265,11 @@ contract Bootstrap is
         if (bytes(ethToExocoreAddress[msg.sender]).length == 0) {
             revert Errors.BootstrapValidatorNotExist();
         }
+        // check that the consensus key is not empty.
+        if (newKey == bytes32(0)) {
+            revert Errors.ZeroValue();
+        }
+        // check that the consensus key is unique.
         if (consensusPublicKeyInUse[newKey]) {
             revert Errors.BootstrapConsensusPubkeyAlreadyUsed(newKey);
         }

diff --git a/test/foundry/unit/Bootstrap.t.sol b/test/foundry/unit/Bootstrap.t.sol
@@ -425,6 +425,17 @@ contract BootstrapTest is Test {
         bootstrap.registerValidator(exo, name, commission, pubKey);
     }
 
+    function test03_RegisterValidator_ZeroConsensusKey() public {
+        IValidatorRegistry.Commission memory commission = IValidatorRegistry.Commission(0, 1e18, 1e18);
+        // Register validator
+        string memory exo = "exo13hasr43vvq8v44xpzh0l6yuym4kca98f87j7ac";
+        string memory name = "validator1";
+        bytes32 pubKey = bytes32(0);
+        vm.startPrank(addrs[0]);
+        vm.expectRevert(Errors.ZeroValue.selector);
+        bootstrap.registerValidator(exo, name, commission, pubKey);
+    }
+
     function test04_DepositThenDelegate() public {
         // since deposit and delegate are already tested, we will just do a simple success
         // check here to ensure the reentrancy modifier works.
@@ -493,6 +504,15 @@ contract BootstrapTest is Test {
         vm.stopPrank();
     }
 
+    function test05_ReplaceKey_ZeroConsensusKey() public {
+        test03_RegisterValidator();
+        vm.startPrank(addrs[0]);
+        bytes32 newKey = bytes32(0);
+        vm.expectRevert(Errors.ZeroValue.selector);
+        bootstrap.replaceKey(newKey);
+        vm.stopPrank();
+    }
+
     function test06_UpdateRate() public {
         IValidatorRegistry.Commission memory commission = IValidatorRegistry.Commission(0, 1e18, 1e18);
         // Register one validator