-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSCServer with optional Bonjour service and Package.swift #61
Open
soundflix
wants to merge
72
commits into
ExistentialAudio:dev
Choose a base branch
from
soundflix:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Package.swift
Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift
changed bonjourName to optional type change name to optional type bonjourName default = nil
Hey thanks for the changes. These are a welcome addition. Just want to double check that you're fine with everything becoming MIT since you haven't signed the CLA. Let me know if you have any questions. |
Update Package.swift
changed var host to access level public
add Swift Package installation instructions
I want to test 'NWConnection.State' possibilities. We should integrate some kind of status checking. added public var state: NWConnection.State correction: self.state Update OSCClient.swift Update OSCClient.swift Update OSCClient.swift Update OSCServer.swift Update OSCClient.swift Update OSCClient.swift Update OSCServer.swift Update OSCServer.swift Update OSCServer.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.