Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermal expansion coefficient consolidation #1365

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Thermal expansion coefficient consolidation #1365

wants to merge 2 commits into from
+77 −9

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Nov 21, 2024

Summary

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@hgopalan
Copy link
Contributor

This assumes user specifies thermal_expansion_coeff but what if reference_temperature is specified instead?

@marchdf
Copy link
Contributor Author

marchdf commented Nov 21, 2024

Nothing to see here for now. Don't worry, I will get there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marchdf @hgopalan