Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap the camera to the nearest 90 degrees if we're close enough #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ZakFahey
Copy link

@ZakFahey ZakFahey commented Feb 3, 2024

While playing the game I was bothered by the fact that the camera can get misaligned to where it's just a few degrees shy of straight forward. This makes it annoying to line up some jumps. So now, when you get within 18 degrees of one of the four 90 degree directions, you'll snap straight ahead. I played around with the numbers, and this amount of sensitivity feels best (at least with the keyboard; haven't tested with controllers). If you think the number should be lower or higher, let me know. Here is a demonstration of the change: https://www.youtube.com/watch?v=sUO0gDmANLQ

I checked and this doesn't break how the camera moves when you round a corner while climbing. No regressions from what I can tell.

@ZakFahey
Copy link
Author

ZakFahey commented Feb 3, 2024

Noticing that even after this, if you move left or right, the camera tilts a bit, which makes Madeline move at a slight angle. I've missed a bunch of jumps due to this, but removing that effect wouldn't be ideal either. Maybe an option to remove it would be good, or perhaps the left-right camera tilt shouldn't affect player direction. What do you think?

While playing the game I was bothered by the fact that the camera can get misaligned to where it's just a few degrees shy of straight forward. This makes it annoying to line up some jumps. So now, when you get within 18 degrees of one of the four 90 degree directions, you'll snap straight ahead. I played around with the numbers, and this amount of sensitivity feels best. If you think the number should be lower or higher, let me know. Here is a demonstration of the change: https://www.youtube.com/watch?v=sUO0gDmANLQ
@ZakFahey
Copy link
Author

ZakFahey commented Feb 4, 2024

I've rebased this on top of #45 to help prevent merge conflicts.

@NoelFB
Copy link
Contributor

NoelFB commented Feb 4, 2024

This is a cool idea but it also feels like a fairly big change to how the game controls (even though I agree as it currently is the Camera is fairly unwieldy). I'm hesitant to include this right now but I am gonna pull and try it out soon.

@ZakFahey
Copy link
Author

ZakFahey commented Feb 4, 2024

Yeah my intent here is for this to be subtle enough that players won't notice it, but if they want the camera angle to be aligned with the grid, they easily can. If they want the camera to be slightly offset, it shouldn't snap back when they're not expecting it. As it is now though, because the camera rotation speed isn't perfectly divisible, it's often not possible at all to get the preferred camera angle, even with frame perfect button presses.

To that effect I did notice that if you're at one of the snapped angles and you lightly tap A or D, it quickly snaps right back, which does feel a little unnatural and breaks the "players shouldn't notice this" rule. It's a bit of a nitpick but I could understand wanting to hardcore a special case to handle this.

@iProgramMC
Copy link
Contributor

Noticing that even after this, if you move left or right, the camera tilts a bit, which makes Madeline move at a slight angle.

PR #60 fixed that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants