[ minor ] bugfix in model_commo_properties / LossScale

- This commit fixes a minor error to print error log. - This commit adds a condition to print the error log. Signed-off-by: Eunju Yang <[email protected]>
EunjuYang · Dec 20, 2024 · 18635c2 · 18635c2
1 parent e5bf9d2
commit 18635c2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/nntrainer/models/model_common_properties.cpp b/nntrainer/models/model_common_properties.cpp
@@ -43,8 +43,10 @@ ModelTensorDataType::ModelTensorDataType(ModelTensorDataTypeInfo::Enum value) {
 LossScale::LossScale(float value) { set(value); }
 
 bool LossScale::isValid(const float &value) const {
-  ml_loge("Loss scale cannot be 0");
-  return value != 0;
+  bool is_valid = (std::fpclassify(value) != FP_ZERO);
+  if (!is_valid)
+    ml_loge("Loss scale cannot be 0");
+  return is_valid;
 }
 
 } // namespace nntrainer::props