Eliminate busywaiting in ChannelRx

Eugeny · Oct 27, 2023 · 5defc91 · 5defc91
1 parent 02899e9
commit 5defc91
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/russh/src/channels/io/rx.rs b/russh/src/channels/io/rx.rs
@@ -1,9 +1,8 @@
 use std::io;
 use std::pin::Pin;
-use std::task::{Context, Poll};
+use std::task::{Context, Poll, ready};
 
 use tokio::io::AsyncRead;
-use tokio::sync::mpsc::error::TryRecvError;
 
 use super::{ChannelAsMut, ChannelMsg};
 use crate::ChannelId;
@@ -43,15 +42,9 @@ where
     ) -> Poll<io::Result<()>> {
         let (msg, mut idx) = match self.buffer.take() {
             Some(msg) => msg,
-            None => match self.channel.as_mut().receiver.try_recv() {
-                Ok(msg) => (msg, 0),
-                Err(TryRecvError::Empty) => {
-                    cx.waker().wake_by_ref();
-                    return Poll::Pending;
-                }
-                Err(TryRecvError::Disconnected) => {
-                    return Poll::Ready(Ok(()));
-                }
+            None => match ready!(self.channel.as_mut().receiver.poll_recv(cx)) {
+                Some(msg) => (msg, 0),
+                None => return Poll::Ready(Ok(())),
             },
         };