Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT TO MERGE] Pod v4 new #1229

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from
Draft

[NOT TO MERGE] Pod v4 new #1229

wants to merge 28 commits into from

Conversation

Badatos
Copy link
Collaborator

@Badatos Badatos commented Nov 21, 2024

This PR is here to compare changes mades from Pod V3 DEV to Pod V4.

Summary of changes:

  • Replace Django 3.2 by 4.2
  • Remove Python 3.8 from compatible py versions, and add 3.12
  • Remove Compatibility with ES 6
  • Remove Shibboleth authentification (Brown-University-Library/django-shibboleth-remoteuser hasn't been updated since Jan 20, 2021 and isn't compatible with Django 4.2)

Detailed changes:

  • Improve security in pod playlists, as suggested by CodeQL
  • Remove USE_L10N deprecated param
  • Replace some re_path() by path()
  • Replace remaining ugettext by gettext
  • Replace admin.site.register() call by @admin.register decorator
  • Replace HTTP_X_REQUESTED_WITH by headers={"x-requested-with"
  • Replace request.META by headers
  • Replace assertQuerysetEqual by assertQuerySetEqual
  • Replace force_text by force_str
  • Remove default_app_config in init.py
  • Replace js_asset by django.templatetags.static, as js_asset is deprecated

Badatos and others added 13 commits October 24, 2024 12:10
* Upgrade securtity dependances
* Remove deprecated django-tagging
* Add new django-tagulous
* Elasticsearch default version is Now 8 (remove compatibility with ES 6)
* Replace deprecated ugettext_lazy by gettext_lazy
* Add some temporary deprecations Hacks for cas-client & Chunked-upload
* Replace deprecated url() by re_path()
* Disable all Pods apps by default
* Correct error handling for ElasticSearch
# Conflicts:
#	pod/settings.py
* Replace some re_path() by path()
* Replace remaining ugettext by gettext
* Replace admin.site.register() call by @admin.register decorator
* Replace HTTP_X_REQUESTED_WITH by `headers={"x-requested-with"`
* Replace request.META by headers
* Replace `assertQuerysetEqual` by `assertQuerySetEqual`
* Replace force_text by force_str
* Remove default_app_config in __init__.py
…select2 CSS calls)

* Correct Enrichment form validation process
* Replace Django 3.2 by 4.2 in all links
# Conflicts:
#	pod/settings.py
@Badatos Badatos self-assigned this Nov 21, 2024
pod/playlist/views.py Fixed Show fixed Hide fixed
pod/playlist/views.py Fixed Show fixed Hide fixed
pod/playlist/views.py Fixed Show fixed Hide fixed
pod/playlist/views.py Fixed Show fixed Hide fixed
pod/playlist/views.py Fixed Show fixed Hide fixed
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
pod/playlist/views.py Fixed Show fixed Hide fixed
* Disable Shib Middleware tests as it seems deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant