Prevent /editsign on waxed signs #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add a message warning that the command failed because the sign is waxed, does anyone have any idea what the message should look like? |
JRoy
reviewed
Aug 25, 2023
Essentials/src/main/java/com/earth2me/essentials/commands/Commandeditsign.java
Outdated
Show resolved
Hide resolved
SrBedrock
changed the title
JRoy
approved these changes
Aug 28, 2023
mdcfe
approved these changes
Aug 28, 2023
JRoy
pushed a commit
that referenced
this pull request
Sep 22, 2023
JRoy
pushed a commit
that referenced
this pull request
Sep 22, 2023
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #5473
Details
Proposed feature:
essentials.editsign.waxed.exemptCalling the SignEditEvent when copying a sign with/editsign copyEnvironments tested:
OS: Windows
Java version: 17
Most recent Paper version (1.20.1, git-Purpur-2044)
Demonstration: