Add whitelist indicator for /seen and /whois #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
requested changes
Aug 22, 2023
Essentials/src/main/java/com/earth2me/essentials/commands/Commandwhois.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/commands/Commandseen.java
Outdated
Show resolved
Hide resolved
JRoy
added
type: enhancement
JRoy
reviewed
Aug 23, 2023
JRoy
approved these changes
Aug 23, 2023
|
Thanks |
JRoy
changed the title
|
Thank you so much for this! |
cnie109
added a commit
to cnie109/Essentials
that referenced
this pull request
Aug 24, 2023
Add whitelist indicator for /seen and /whois (EssentialsX#5486)
|
You guys are amazing: |
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
Co-authored-by: Josh Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #5481.
Details
Proposed feature:
I've added a whitelist indicator on the commands whois and seen
When executing /whois the whitelist status of the target player will be displayed at the end as TRUE or FALSE
When executing /seen and if the target player is offline the whitelist status of the target player will be displayed at the end as TRUE or FALSE
Environments tested:
OS: MacOS 13.4.1
Java version: 17.0.5
Demonstration:
Before: https://imgur.com/a/mSFLzye
After: https://imgur.com/a/jiMvcmN