Rework the provider system #5087
Open
+701
−572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: enhancement
pop4959
reviewed
Aug 24, 2022
...SReflectionProvider/src/main/java/net/ess3/nms/refl/providers/ReflDataWorldInfoProvider.java
Outdated
Show resolved
Hide resolved
providers/BaseProviders/src/main/java/net/ess3/provider/providers/FlatSpawnEggProvider.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/ProviderFactory.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/ProviderFactory.java
Outdated
Show resolved
Hide resolved
pop4959
previously approved these changes
Aug 24, 2022
|
should rebase to dev/2.20 branch, otherwise lgtm |
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/IEssentials.java
kennytv
reviewed
Nov 8, 2022
Essentials/src/main/java/com/earth2me/essentials/ProviderFactory.java
Outdated
Show resolved
Hide resolved
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/signs/SignEnchant.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Kit.java
mdcfe
previously requested changes
Dec 18, 2023
There was a problem hiding this comment.
Every provider getter is still objectively worse to both read and write than before. I'm still in favour of improving provider internals, but this PR either needs to retain the old provider getters, or significantly clean up provider usage to remove the repeated getter calls everywhere.
people may forget what these things do later
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java # Essentials/src/main/java/com/earth2me/essentials/IEssentials.java # Essentials/src/main/java/com/earth2me/essentials/Kit.java # Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java # Essentials/src/main/java/com/earth2me/essentials/Settings.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandanvil.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandcartographytable.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandcreatekit.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandgrindstone.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandloom.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandsmithingtable.java # Essentials/src/main/java/com/earth2me/essentials/commands/Commandstonecutter.java # Essentials/src/main/java/com/earth2me/essentials/commands/EssentialsCommand.java # Essentials/src/main/java/com/earth2me/essentials/items/FlatItemDb.java # Essentials/src/main/java/com/earth2me/essentials/items/LegacyItemDb.java # Essentials/src/main/java/com/earth2me/essentials/signs/SignAnvil.java # Essentials/src/main/java/com/earth2me/essentials/signs/SignCartography.java # Essentials/src/main/java/com/earth2me/essentials/signs/SignGrindstone.java # Essentials/src/main/java/com/earth2me/essentials/signs/SignLoom.java # Essentials/src/main/java/com/earth2me/essentials/signs/SignSmithing.java # Essentials/src/main/java/com/earth2me/essentials/utils/LocationUtil.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java # Essentials/src/main/java/com/earth2me/essentials/IEssentials.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java # Essentials/src/main/java/com/earth2me/essentials/IEssentials.java # Essentials/src/main/java/com/earth2me/essentials/RandomTeleport.java # Essentials/src/main/java/com/earth2me/essentials/commands/EssentialsCommand.java # Essentials/src/main/java/com/earth2me/essentials/items/FlatItemDb.java # providers/BaseProviders/src/main/java/net/ess3/provider/providers/BasePotionDataProvider.java # providers/BaseProviders/src/main/java/net/ess3/provider/providers/LegacyPotionMetaProvider.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/AlternativeCommandsHandler.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/commands/Commandrecipe.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java # Essentials/src/main/java/com/earth2me/essentials/RandomTeleport.java
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Settings.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's perfect
event providers are still ugly and im not touching them