We're going on an Adventure! #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
added
type: enhancement
zml2008
suggested changes
Dec 28, 2021
Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java
Outdated
Show resolved
Hide resolved
Turns out that adventure-platform registers events which are required to create an audience for them. Move the creation of the BukkitAudiences object after we unregister all of our events.
…is i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this i hate this
JRoy
force-pushed
the
refactor/we-are-going-on-an-adventure
branch
from
8c538dc
to
2f38558
Compare
…y head get out of my head get out of my head get out of my head get out of my head
kashike
reviewed
Dec 29, 2021
Essentials/src/main/java/com/earth2me/essentials/CommandSource.java
Outdated
Show resolved
Hide resolved
… i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die i want to die
This reverts commit 90103ba.
JRoy
commented
Nov 5, 2023
…g-on-an-adventure
|
Just your friendly neighborhood server admin, I was wondering if we could get a progress report of some kind. I really appreciate yall's work, and also had a few questions regarding these changes that the answers to are probably well-known to EssentialsX developers, but I have not been able find answers to elsewhere:
I don't want to be a nag, but I really do appreciate your work and would like to know how this all is going so far, thank you all very much! |
Co-authored-by: pop4959 <[email protected]>
people may forget what these things do later
Still LGTM |
mdcfe
previously approved these changes
Feb 3, 2024
|
When a player joins the server, an error is sent: https://pastes.dev/YbBHLlf2fw
|
Any chance you were live swapping the EssX jar in the |
mdcfe
approved these changes
Feb 3, 2024
|
@SrBedrock The PR has been updated to shade the missing options library - would you be able to update to the latest dev build? |
sarhatabaot
added a commit
to Lapzupi/Essentials
that referenced
this pull request
Apr 6, 2024
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
https://user-images.githubusercontent.com/10731363/147530817-f9adc58e-18a5-49ed-84c6-106e51d6948f.mp4 Add support for chat components throughout EssentialsX using the Adventure library. Translations have been converted to the MiniMessage format, and custom message files will be migrated on startup. This also introduces new options to allow players to see messages in their own language and for server owners to change the main message colours without editing message files. Closes EssentialsX#2029 Closes EssentialsX#2391 --------- Co-authored-by: MD <[email protected]> Co-authored-by: pop4959 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
im.going.on.an.adventure.mp4
Closes #2029
Closes #2391
Todo