Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unity] Immutable Triangles has no effect by default #2636

Open
HaraldCsaszar opened this issue Sep 18, 2024 · 1 comment
Open

[unity] Immutable Triangles has no effect by default #2636

HaraldCsaszar opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels

Comments

@HaraldCsaszar
Copy link
Collaborator

HaraldCsaszar commented Sep 18, 2024

Reported on the forum here:
https://esotericsoftware.com/forum/d/26850-question-about-the-spine_trianglecheck-/7

When the define SPINE_TRIANGLECHECK is active (the default), immutableTriangles has no effect.

Fix:
Correct the line ~154 in SkeletonRendererInstruction.cs GeometryNotEqual to:

if (a.immutableTriangles != b.immutableTriangles) return true;
if (a.immutableTriangles) return false; // newly added line

and move this block further up, below if (a.hasActiveClipping || b.hasActiveClipping) return true; .
As this is a breaking change, apply this patch in next beta (4.3-beta).

@HaraldCsaszar HaraldCsaszar self-assigned this Sep 18, 2024
@HaraldCsaszar
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant