Requested changes

worlds/sc2/test/test_custom_mission_orders.py

@@ -5,6 +5,7 @@
 from .test_base import Sc2SetupTestBase
 from .. import MissionFlag
 from .. import item_names
+from .. import items
 from BaseClasses import ItemClassification
 
 class TestCustomMissionOrders(Sc2SetupTestBase):
@@ -125,6 +126,8 @@ def test_locked_and_necessary_item_appears_once(self):
          }
       }
 
+      self.assertNotEqual(items.item_table[test_item].classification, ItemClassification.progression, f"Test item {test_item} won't change classification")
+
       self.generate_world(world_options)
       test_items_in_pool = [item for item in self.multiworld.itempool if item.name == test_item]
       self.assertEqual(len(test_items_in_pool), 1)
@@ -156,8 +159,6 @@ def test_start_inventory_and_necessary_item_appears_once(self):
       self.assertEqual(len(test_items_in_pool), 0)
       test_items_in_start_inventory = [item for item in self.multiworld.precollected_items[self.player] if item.name == test_item]
       self.assertEqual(len(test_items_in_start_inventory), 1)
-      # Start inventory gets a new item so the classification is no longer progression
-      self.assertEqual(test_items_in_start_inventory[0].classification, ItemClassification.filler)
 
    def test_start_inventory_and_locked_and_necessary_item_appears_once(self):
       # This is a filler upgrade with a parent
@@ -186,5 +187,3 @@ def test_start_inventory_and_locked_and_necessary_item_appears_once(self):
       self.assertEqual(len(test_items_in_pool), 0)
       test_items_in_start_inventory = [item for item in self.multiworld.precollected_items[self.player] if item.name == test_item]
       self.assertEqual(len(test_items_in_start_inventory), 1)
-      # Start inventory gets a new item so the classification is no longer progression
-      self.assertEqual(test_items_in_start_inventory[0].classification, ItemClassification.filler)