Watchdog notifications - #344 Watchdog bites with no warning #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checks say that there are some failures, however the failures seem to be internal failures in the test tools. @SRGDamia1 if I should be doing something about this please let me know. |
|
This bit me pretty hard, so I submitted it as an improvement. Watchdog is valuable when something goes wrong, but it is double edged. If this PR is not desirable I will delete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code I'm using so that the watchdog gives some notice before RESETING and tested it in my own environment for a week.
I've built in https://github.com/EnviroDIY/ModularSensors (develop) but not run tests on it.
Fixes #344