Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included schema scope options for -allSchemas and multiple schemas on Invoking MTK page #6032

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

gvasquezvargas
Copy link
Contributor

@gvasquezvargas gvasquezvargas commented Sep 9, 2024

What Changed?

  • I created a new section dedicated to schema_scope here, where I added an overview table with the three possibilities per OS (single schema, multiple schemas, all schemas).

  • I added examples for each of the three schema scope variations in expandable sections for migrations from Oracle and also for migrations from non-Oracle. I did this using expandable snippets.

  • The original "invoking MTK" page included an MTK error message, which felt noisy and out of place. I moved that to the error messages page. But also made sure to drop a note telling customers about the minimal toolkit.properties permissions required to run the command.

  • I altered mentions of <schema_name> to <schema_scope> in most places. In some spots where <schema_name> refers to the actual name of the schema, I left it untouched.

https://enterprisedb.atlassian.net/browse/DOCS-1022

@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Sep 9, 2024
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner September 9, 2024 10:15
Copy link
Contributor

github-actions bot commented Sep 9, 2024

@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 9, 2024 10:24 Inactive
@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 9, 2024 16:29 Inactive
@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 10, 2024 09:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 10, 2024 09:25 Inactive
@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 10, 2024 12:45 Inactive
Copy link

@zahid75 zahid75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, suggested a couple of changes.

@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 25, 2024 11:33 Inactive
Copy link

@zahid75 zahid75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes are in place.

@github-actions github-actions bot temporarily deployed to pr-6032-mtk-schema_scope September 26, 2024 07:24 Inactive
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One warning:
Line 31 of 06_building_toolkit_properties_file needs to have the anchor migrating-from-a-non-oracle-source-database changed to migrating-schemas-from-a-non-oracle-source-database

@gvasquezvargas gvasquezvargas merged commit 612bc3e into develop Sep 27, 2024
3 checks passed
@gvasquezvargas gvasquezvargas deleted the mtk/schema_scope branch September 27, 2024 11:56
@djw-m djw-m mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants