-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included schema scope options for -allSchemas
and multiple schemas on Invoking MTK page
#6032
Conversation
...tion_toolkit/55/07_invoking_mtk/mtk_command_options_in_file/executing_migration_with_txt.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, suggested a couple of changes.
product_docs/docs/migration_toolkit/55/07_invoking_mtk/index.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/migration_toolkit/55/07_invoking_mtk/index.mdx
Outdated
Show resolved
Hide resolved
8753587
to
bba38b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes are in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One warning:
Line 31 of 06_building_toolkit_properties_file needs to have the anchor migrating-from-a-non-oracle-source-database changed to migrating-schemas-from-a-non-oracle-source-database
What Changed?
I created a new section dedicated to schema_scope here, where I added an overview table with the three possibilities per OS (single schema, multiple schemas, all schemas).
I added examples for each of the three schema scope variations in expandable sections for migrations from Oracle and also for migrations from non-Oracle. I did this using expandable snippets.
The original "invoking MTK" page included an MTK error message, which felt noisy and out of place. I moved that to the error messages page. But also made sure to drop a note telling customers about the minimal toolkit.properties permissions required to run the command.
I altered mentions of <schema_name> to <schema_scope> in most places. In some spots where <schema_name> refers to the actual name of the schema, I left it untouched.
https://enterprisedb.atlassian.net/browse/DOCS-1022