Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDBC - Advance Queuing update #6031

Merged
merged 10 commits into from
Sep 10, 2024
Merged

JDBC - Advance Queuing update #6031

merged 10 commits into from
Sep 10, 2024

Conversation

nidhibhammar
Copy link
Contributor

@nidhibhammar nidhibhammar commented Sep 6, 2024 •
edited by jira bot
Loading

What Changed?

Addresses EC-3136

@nidhibhammar nidhibhammar added the deploy Add this label to a PR and it will automatically be deployed to netlify label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-6031--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 6, 2024 14:42 Inactive
@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 9, 2024 11:07 Inactive
@nidhibhammar nidhibhammar marked this pull request as ready for review September 10, 2024 12:16
@nidhibhammar nidhibhammar requested a review from a team as a code owner September 10, 2024 12:16
@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 10, 2024 12:19 Inactive
@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 10, 2024 12:40 Inactive
@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 10, 2024 12:57 Inactive
@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 10, 2024 13:06 Inactive
djw-m
djw-m approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the odd formatting in the release notes (see comment),
(Though I think the original authors may consider breaking up their advanced queueing section)

@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 10, 2024 13:23 Inactive
ericmack
ericmack approved these changes Sep 10, 2024
View reviewed changes
Copy link

@ericmack ericmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better formatting.

@nidhibhammar
Copy link
Contributor Author

Apart from the odd formatting in the release notes (see comment), (Though I think the original authors may consider breaking up their advanced queueing section)

Yes, fixed the formatting. Also breaking of the section is been discussed with the team and will be implemented soon. Thanks!

@github-actions github-actions bot temporarily deployed to pr-6031-content-docs-jdbc-advance_queuing September 10, 2024 13:30 Inactive
@nidhibhammar nidhibhammar merged commit 99ba39c into develop Sep 10, 2024
2 of 3 checks passed
@nidhibhammar nidhibhammar deleted the content/docs/jdbc/advance_queuing branch September 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw-m djw-m djw-m approved these changes

@ericmack ericmack ericmack approved these changes

@moazzumali moazzumali Awaiting requested review from moazzumali

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nidhibhammar @ericmack @djw-m