Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDE: specify AES implementation is done with OpenSSL #6030

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

gvasquezvargas
Copy link
Contributor

@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Sep 6, 2024
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner September 6, 2024 13:10
Copy link
Contributor

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pr-6030-tde-openssl2 September 6, 2024 13:21 Inactive
@github-actions github-actions bot temporarily deployed to pr-6030-tde-openssl2 September 6, 2024 14:24 Inactive
@github-actions github-actions bot temporarily deployed to pr-6030-tde-openssl2 September 6, 2024 14:31 Inactive
### How does TDE encrypt data?
### How does TDE encrypt data?

EDB TDE uses [OpenSSL](https://openssl-library.org/) to encrypt data files with the AES encryption algorithm. In Windows systems, TDE uses [OpenSSL 3](https://docs.openssl.org/3.0/). In Linux systems, TDE uses the OpenSSL version installed in the host operating system. To check the installed version, run `openssl version`. For more details, refer to the [OpenSSL documentation](https://docs.openssl.org/master/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the wording "OpenSSL that their operating system installs as a server package dependency" just because some customers will use a build of OpenSSL that does not come from the OpenSSL community e.g.. With the wording change mentioned here, I'd change the last sentence to "For more information, see the OpenSSL documentation. If you're using a custom build not provided by the OpenSSL community, consult your vendor's documentation."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I made the changes ✅

Copy link

@MattWalliEDB MattWalliEDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to pr-6030-tde-openssl2 September 9, 2024 09:05 Inactive
@gvasquezvargas gvasquezvargas merged commit 4e9c345 into develop Sep 10, 2024
3 checks passed
@gvasquezvargas gvasquezvargas deleted the TDE/openssl2 branch September 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants