Added note on non-ascii characters not being supported #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvasquezvargas
added
the
deploy
github-actions
bot
temporarily deployed
to
pr-6024-postgresql-installer_limitation
gvasquezvargas
force-pushed
the
postgresql/installer_limitation
branch
from
c5c19fb
to
c86c8fd
Compare
github-actions
bot
temporarily deployed
to
pr-6024-postgresql-installer_limitation
gvasquezvargas
force-pushed
the
postgresql/installer_limitation
branch
from
c86c8fd
to
4b3686e
Compare
github-actions
bot
temporarily deployed
to
pr-6024-postgresql-installer_limitation
josh-heyer
requested changes
Sep 6, 2024
There was a problem hiding this comment.
IIRC, the reason this was never entered was that it isn't strictly true; there appear to be certain combinations of multi-byte character names that will cause issues, but I'm not sure what the specific scenario is. That said, saying "we don't support" (vs the passive "are not supported") is probably a reasonable statement.
gvasquezvargas
commented
Sep 9, 2024
advocacy_docs/supported-open-source/postgresql/installing/windows.mdx
Outdated
Show resolved
Hide resolved
gvasquezvargas
commented
Sep 9, 2024
| !!! Note | ||
| If you're using the graphical installation wizard to perform a system upgrade, the installer preserves the configuration options specified during the previous installation. | ||
| !!!note Notes | ||
| - EDB doesn't support all non-ASCII, multi-byte characters in user or machine names. Use ASCII characters only to avoid installation errors related to unsupported path names. |
There was a problem hiding this comment.
@josh-heyer I reworded this a bit to clarify that not all characters are affected and that it is an EDB installation limitation. I also added an active recommendation/alternative. WDYT?
github-actions
bot
temporarily deployed
to
pr-6024-postgresql-installer_limitation
gvasquezvargas
force-pushed
the
postgresql/installer_limitation
branch
from
2563c0b
to
42fbf93
Compare
josh-heyer
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
We found a Jira (https://enterprisedb.atlassian.net/browse/DOCS-1007) for an old GitHub issue #3490.
The conclusion of the discussion was that we need a note with a disclaimer that non-ascii characters are not supported for user or machine names for PostgreSQL installations/upgrades to work on Windows with the wizard.