Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ortholog and topup clustering modes #873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Oct 27, 2024

Description

This PR would remove the ortholog and topup clustering modes from the gene-tree pipelines.

Neither mode has been used in production for quite some time. Furthermore, topup mode has been broken since release/110, since it uses a runnable (CopyTreesFromDB) which calls the obsolete method MemberAdaptor::fetch_by_stable_id.

Related JIRA tickets:

Overview of changes

This draft PR would:

  • remove the option to configure ortholog or topup clustering mode from the protein-trees pipeline, and remove the ortholog clustering mode from the ncRNA-trees pipeline;
  • remove all pipeline analyses related to the ortholog and topup clustering modes;
  • remove related pipeline parameters, including the copy and raxml_update clusterset_ids;
  • add deprecation information to each of the runnables involved in the ortholog and topup clustering modes, and to the seq_member_id_current_reused_map table in pipeline-tables.sql; and
  • add a treebreak_decision pipeline step to simplify the pipeline in the vicinity of the QuickTreeBreak loop.

This image shows a section of the pipeline following these changes:
sans_topup_mode

Testing

These changes were tested during a run of the Pan Compara protein-trees pipeline as part of release/114 production.

(Some minor changes to documentation and parameters were made after the pipeline run.)


For code reviewers: code review SOP

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (cd1e53c) to head (9cefb09).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #873       +/-   ##
===========================================
+ Coverage   60.67%   73.04%   +12.37%     
===========================================
  Files         212       15      -197     
  Lines       23016      564    -22452     
  Branches     3627        0     -3627     
===========================================
- Hits        13966      412    -13554     
+ Misses       7833      152     -7681     
+ Partials     1217        0     -1217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twalsh-ebi twalsh-ebi marked this pull request as ready for review November 25, 2024 16:15
@twalsh-ebi twalsh-ebi force-pushed the future/cluster_mode_cleanup branch from de123c3 to 9cefb09 Compare December 2, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants