Remove ortholog and topup clustering modes #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR would remove the
ortholog
andtopup
clustering modes from the gene-tree pipelines.Neither mode has been used in production for quite some time. Furthermore, topup mode has been broken since
release/110
, since it uses a runnable (CopyTreesFromDB
) which calls the obsolete methodMemberAdaptor::fetch_by_stable_id
.Related JIRA tickets:
Overview of changes
This draft PR would:
ortholog
ortopup
clustering mode from the protein-trees pipeline, and remove theortholog
clustering mode from the ncRNA-trees pipeline;ortholog
andtopup
clustering modes;copy
andraxml_update
clusterset_ids;ortholog
andtopup
clustering modes, and to theseq_member_id_current_reused_map
table inpipeline-tables.sql
; andtreebreak_decision
pipeline step to simplify the pipeline in the vicinity of theQuickTreeBreak
loop.This image shows a section of the pipeline following these changes:
Testing
These changes were tested during a run of the Pan Compara protein-trees pipeline as part of
release/114
production.(Some minor changes to documentation and parameters were made after the pipeline run.)
For code reviewers: code review SOP