Add new British Gas format #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporarily updated this branch to refer to our forked version of roo and an updated version of the analytics. Will update this again when tagged release of analytics is available. |
|
Updated to use tagged branch |
urbanwide
approved these changes
Nov 14, 2023
ldodds
deleted the
3870-could-we-have-a-new-data-configuration-for-the-new-british-gas-feed-please
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration to support new format provided by British Gas.
Testing shows that we're getting parsing errors. These will be fixed by:
These fixes have been used to create a branch in our forked version of Roo. So this PR also:
The side effect of the analytics update is that a couple of other bug fixes have been introduced (see: Energy-Sparks/energy-sparks_analytics#624 and Energy-Sparks/energy-sparks_analytics#625). But the first of these has previously been released to test.