Build ElmerIce with netCDF in CI on Ubuntu #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with the CMake config file that is installed by netCDF for Fortran is already fixed upstream: Until that change is included in a released version and that version finds its way into the packages that are distributed, it is probably be best to keep using the FindNETCDF.cmake module that is part of the ElmerFEM sources. When these newer versions of netCDF for Fortran are starting to appear, it should be easy to adapt the FindNETCDF.cmake module to pick the fixed config file up if available. |
ElmerIce requires MPI. So, install netCDF only for the jobs that build with MPI.
Newer versions of netCDF install a CMake config file. But the CMake config file of netCDF for Fortran cannot be used currently. Make sure to use the CMake find module bundled with Elmer to detect netCDF and netCDF for Fortran.
The netCDF Fortran library depends on the netCDF library. For some linkers (e.g., ld.bfd), the linking order matters. Make sure to have the netCDF Fortran library *before* the netCDF library in the linker flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.