Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #6

Merged

Conversation

fearnlj01
Copy link

This should fix layout jumping while new query results are being fetched in the summary page. A loading indicator is shown in the header for each group of results, so in the event of a slow response, it should be clear that the data is currently updating.

There's probably a better way to go about this, but this was the best I could find in the tanstack documentation quickly!

I will do a follow up PR to rebase all the changes thus far on top of ShokoServer-WebUI/master once/if this has been merged.

@fearnlj01 fearnlj01 changed the title Series redesign Fix: Layout jumping in file summary May 7, 2024
@fearnlj01
Copy link
Author

I wouldn't have originally virtualized the credits tab, however Detective Conan was able to cause my browser to hang the instant I navigated to the credits tab. Interestingly, I didn't get any notable performance issues when testing with One Piece, so the "sweet spot" for a breakdown in performance appears to lie somewhere between those two series.

I'm also not sure if SeriesCredits.tsx warrants being broken up into components properly across different files - I will await further instruction before doing anything on this.

@fearnlj01 fearnlj01 changed the title Fix: Layout jumping in file summary Misc changes May 7, 2024
@fearnlj01 fearnlj01 marked this pull request as draft May 8, 2024 11:47
@fearnlj01
Copy link
Author

I need to make changes to double check the latest two Shoko Server commits don't cause any issues. I expect I will need to refactor the Collection > Files tab somewhat as a result, so marking the PR as a draft until this is reviewed and any changes added.

@fearnlj01
Copy link
Author

Just as a note on the file summary panel changing... It looks like I skipped over this a bit too much in previous passes. If you have a long list of subtitle languages, the layout ended up jumping wildly.

Additional constraints on the display have been added in order to deal with worst case scenarios in the best possible manner - hopefully this matches expectations.

For testing reference... the list of different subtitle languages that caused me problems is as below:

ara, chi, cze, dan, dut, ell, eng, fin, fre, ger, heb, hin, hrv, hun, ind, ita, jpn, kor, may, nob, pol, por, rum, spa, swe, tha, tur, ukr, unk, vie

@fearnlj01
Copy link
Author

Since I've been looking at it again following the removal of the hack to include Video Resolution... Perhaps it would be worth re-including some of the implicitly removed options for grouping in the file summary.

Not sure if there's any good way of presenting each option however!

@fearnlj01 fearnlj01 marked this pull request as ready for review May 8, 2024 20:18
@ElementalCrisis ElementalCrisis merged commit 9947379 into ElementalCrisis:series-redesign May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants