Merge pull request #2 from EkoLabs/new_urls_event

New urls event
EkoLabs · Jul 22, 2020 · c7c119d · c7c119d
2 parents 836bc13 + 0bb4e83
commit c7c119d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/samples/HelloEko/HelloEko.xcodeproj/project.pbxproj b/samples/HelloEko/HelloEko.xcodeproj/project.pbxproj
@@ -366,7 +366,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 4;
+				CURRENT_PROJECT_VERSION = 7;
 				DEVELOPMENT_TEAM = 32U3WAAGM3;
 				INFOPLIST_FILE = HelloEko/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = (
@@ -385,7 +385,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 4;
+				CURRENT_PROJECT_VERSION = 7;
 				DEVELOPMENT_TEAM = 32U3WAAGM3;
 				INFOPLIST_FILE = HelloEko/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = (

diff --git a/samples/HelloEko/HelloEko/ViewController.swift b/samples/HelloEko/HelloEko/ViewController.swift
@@ -113,7 +113,6 @@ class ViewController: UIViewController, EkoPlayerViewDelegate, EkoUrlDelegate, E
         self.view.addSubview(playerView)
         playerView.frame = CGRect(x: 20, y: 369, width: 374, height: 260)
         playerView.delegate = self
-        playerView.urlDelegate = self
         playerView.appName = "SampleApp"
     }
 

diff --git a/sdk/EkoPlayerSDK/EkoPlayerView.swift b/sdk/EkoPlayerSDK/EkoPlayerView.swift
@@ -303,7 +303,7 @@ enum PlayerEventError : LocalizedError {
             }
 
             // the URL might not be encoded, so encode it before passing it to the delegate
-            if (eventName == "eko.urls.openinparent") {
+            if (eventName == "eko.urls.intent") {
                 if let args = json["args"] as? Array<AnyObject> {
                     if !args.isEmpty, let urlString = args[0]["url"] as? String {
                          if let escapedString = urlString.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) {

diff --git a/sdk/EkoPlayerSDK/EkoProjectLoader.swift b/sdk/EkoPlayerSDK/EkoProjectLoader.swift
@@ -40,8 +40,8 @@ class EkoProjectLoader: NSObject {
                 options.events.append("eko.canplay")
             }
         }
-        if (!options.events.contains("urls.openinparent")) {
-            options.events.append("urls.openinparent")
+        if (!options.events.contains("urls.intent")) {
+            options.events.append("urls.intent")
         }
         if (!options.events.contains("share.intent")) {
             options.events.append("share.intent")
@@ -73,7 +73,7 @@ class EkoProjectLoader: NSObject {
             } else {
                 // attempt to get the embed url from the response, throw an error if unable to
                 if let projectEmbed = data["embedUrl"] as? String {
-                    totalUrl = "\(projectEmbed)?embedapi=1.0&sharemode=proxy\(urlParam)"
+                    totalUrl = "\(projectEmbed)?embedapi=1.0&sharemode=proxy&urlsmode=proxy\(urlParam)"
                 } else {
                     throw LoadingError.malformedResponse(message: "Embed url not found - Missing embed url in response")
                 }