Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search bar #6

Closed
wants to merge 64 commits into from
Closed

search bar #6

wants to merge 64 commits into from

Conversation

qwqtw
Copy link

@qwqtw qwqtw commented Nov 15, 2023

search.bar.demo.mov

Copy link

@chuan-edutrigger chuan-edutrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked your demo video, the locations of those elements are wrong, keep them at the original place instead of putting everything together

lms/djangoapps/courseware/views/views.py Outdated Show resolved Hide resolved
lms/envs/devstack.py Outdated Show resolved Hide resolved
lms/templates/courseware/courses.html Outdated Show resolved Hide resolved
lms/templates/courseware/courses.html Outdated Show resolved Hide resolved
lms/templates/courseware/courses.html Outdated Show resolved Hide resolved
<!-- Filter Section -->
<div class="buttons">
<!-- Filter Box with Icon and Count -->
<img src="../../static/images/filter_icon.png" alt="Filter Icon" class="faders">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use material design icons, and you don't need to import them as an img

lms/templates/courseware/courses.html Outdated Show resolved Hide resolved
lms/templates/courseware/courses.html Outdated Show resolved Hide resolved
@qwqtw qwqtw closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants