Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QW vest 8 search bar #11

Open
wants to merge 17 commits into
base: viceclass-prod
Choose a base branch
from
+350 −34
Open

QW vest 8 search bar #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b068757
feat: modifying search bar for /courses page
qwqtw Nov 28, 2023
21f0c87
fix: fix indentation
qwqtw Nov 28, 2023
f747dbf
fix: PEP8 style
qwqtw Nov 29, 2023
8c14328
fix: error
qwqtw Nov 29, 2023
876e331
fix: style
qwqtw Nov 29, 2023
04e6ad7
fix: revert file
qwqtw Nov 30, 2023
20119b3
fix: revert feat and style
qwqtw Nov 30, 2023
5ae9bf4
fix: refine your search
qwqtw Dec 2, 2023
bad4082
fix: fix style
qwqtw Dec 2, 2023
2e75284
fix: fix style
qwqtw Dec 2, 2023
fa761d3
fix: fix feat
qwqtw Dec 5, 2023
48d9f00
fix: fix XSS
qwqtw Dec 5, 2023
084f9a7
Revert "fix: fix XSS"
qwqtw Dec 5, 2023
c6c7270
fix: fix style
qwqtw Dec 6, 2023
2b56a1f
Revert "fix: fix style"
qwqtw Dec 7, 2023
c7df3cf
fix: fix xss
qwqtw Dec 7, 2023
99405ac
fix: fix bold style
qwqtw Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lms/djangoapps/courseware/views/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def courses(request):
"""
courses_list = []
course_discovery_meanings = getattr(settings, 'COURSE_DISCOVERY_MEANINGS', {})
if not settings.FEATURES.get('ENABLE_COURSE_DISCOVERY'):
if settings.FEATURES.get('ENABLE_COURSE_DISCOVERY'):
courses_list = get_courses(request.user)

if configuration_helpers.get_value("ENABLE_COURSE_SORTING_BY_START_DATE",
Expand Down
8 changes: 7 additions & 1 deletion lms/envs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@
# .. toggle_target_removal_date: None
# .. toggle_warning: The COURSE_DISCOVERY_MEANINGS setting should be properly defined.
# .. toggle_tickets: https://github.com/openedx/edx-platform/pull/7845
'ENABLE_COURSE_DISCOVERY': False,
'ENABLE_COURSE_DISCOVERY': True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out what will be impacted by this change, and see if you need to make the change in the above file or not


# .. toggle_name: FEATURES['ENABLE_COURSE_FILENAME_CCX_SUFFIX']
# .. toggle_implementation: DjangoSetting
Expand All @@ -679,6 +679,12 @@
# Teams feature
'ENABLE_TEAMS': True,

# Filter feature of the filter bar
'ENABLE_FILTER': False,

# Sort by feature of the filter bar
'ENABLE_SORTBY': False,

# Show video bumper in LMS
'ENABLE_VIDEO_BUMPER': False,

Expand Down
7 changes: 6 additions & 1 deletion lms/envs/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,17 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing
'language': LANGUAGE_MAP,
}

FEATURES['ENABLE_COURSE_DISCOVERY'] = False
FEATURES['ENABLE_COURSE_DISCOVERY'] = True
# Setting for overriding default filtering facets for Course discovery
# COURSE_DISCOVERY_FILTERS = ["org", "language", "modes"]
FEATURES['COURSES_ARE_BROWSEABLE'] = True
HOMEPAGE_COURSE_MAX = 9

FEATURES['ENABLE_FILTER'] = True
# Toggle for the "filter" feature of the search bar
FEATURES['ENABLE_SORTBY'] = False
# Toggle for the "sort by" feature of the search bar

# Software secure fake page feature flag
FEATURES['ENABLE_SOFTWARE_SECURE_FAKE'] = True

Expand Down
Loading
Loading