Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving issue #453 #488

Closed
wants to merge 1 commit into from
Closed

Resolving issue #453 #488

wants to merge 1 commit into from

Conversation

hizclick
Copy link
Contributor

@hizclick hizclick commented Dec 2, 2024

Description, Context and related Issue

Resolving issue Refs #453

How Has This Been Tested?

Tested with Klarinettenquintett

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update
  • Improvement
  • Refactoring

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes at testing
  • All new and existing tests passed.

@hizclick hizclick linked an issue Dec 2, 2024 that may be closed by this pull request
[BUG] old code in getAnnotationsInText.xql #453
Closed
@peterstadler
Copy link
Member

Is this not the same code change as in #487 ?

@krHERO krHERO added this to the 1.0.0 milestone Dec 3, 2024
@bwbohl bwbohl added Type: bugfix A pull request providing a bugfix Status: needs work labels Dec 4, 2024
@hizclick
Copy link
Contributor Author

hizclick commented Dec 4, 2024

Yes, it is the same, thank you. IMO, the solution for both issues is also the same as ; Ie, I will close this PR and commit the changes in PR #487

@hizclick hizclick closed this Dec 4, 2024
@bwbohl
Copy link
Member

bwbohl commented Dec 19, 2024

Can the corresponding branch be deleted?

@hizclick hizclick deleted the 453-bug-old-code-in-getannotationsintextxql branch December 19, 2024 12:58
@hizclick
Copy link
Contributor Author

@bwbohl just did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roewenstrunk roewenstrunk Awaiting requested review from roewenstrunk

@daniel-jettka daniel-jettka Awaiting requested review from daniel-jettka

Assignees

@peterstadler peterstadler

@hizclick hizclick

Labels
Status: needs work Type: bugfix A pull request providing a bugfix
Projects
Edirom Development
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] old code in getAnnotationsInText.xql
4 participants
@hizclick @peterstadler @bwbohl @krHERO