Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr/381 add about edirom #479

Merged
merged 13 commits into from
Dec 2, 2024
Merged

Ftr/381 add about edirom #479

merged 13 commits into from
Dec 2, 2024

Conversation

daniel-jettka
Copy link
Contributor

Description, Context and related Issue

added button and window fpr about page; reads from CITATION.cff to display basic information

Refs #381 and Refs #213

How Has This Been Tested?

local build of Edirom

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Improvement

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@daniel-jettka daniel-jettka linked an issue Nov 21, 2024 that may be closed by this pull request
1 task
@krHERO krHERO added this to the 1.0.0 milestone Nov 22, 2024
@roewenstrunk roewenstrunk self-requested a review November 27, 2024 13:57
Copy link
Member

@roewenstrunk roewenstrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Klarinettenquintett

@roewenstrunk
Copy link
Member

No rebasing possible

@roewenstrunk roewenstrunk merged commit fc3baf8 into develop Dec 2, 2024
4 checks passed
@roewenstrunk roewenstrunk deleted the ftr/381-add-about-edirom branch December 2, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add "About Edirom"
3 participants