Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/432 go to measure… function returns wrong measure #457

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Bug/432 go to measure… function returns wrong measure #457

merged 2 commits into from
Oct 31, 2024

Conversation

hizclick
Copy link
Contributor

Description, Context and related Issue

This PR is a quick fix for the issue 432. Change the code on line number to e6c2430#diff-11ca3497e203008800617bf27e9109f5234eca41d0e5a7452e35a91e94fc494fR27 will look for the first element within a specified movement ($movementId) where either: the @Label attribute equals $measureIdName, or, the @n attribute equals $measureIdName other than relaying only on @n.

Refs #
#432

How Has This Been Tested?

Tasted on weber klarinettenquintett.

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [X ] Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X] I have performed a self-review of my code
  • [ X] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ X] All new and existing tests passed.

peterstadler
peterstadler approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @bwbohl that a "proper refactoring would be the ideal" but for now the proposed PR is a good workaround

@peterstadler peterstadler linked an issue Oct 25, 2024 that may be closed by this pull request
SourceView: go to measure… function returns wrong measure #432
Closed
@peterstadler peterstadler added this to the 1.0.0 milestone Oct 25, 2024
@hizclick hizclick merged commit 29dbe65 into develop Oct 31, 2024
3 checks passed
@hizclick hizclick deleted the bug/432-go-to-measure…-function-returns-wrong-measure branch October 31, 2024 16:14
@DennisFriedl DennisFriedl mentioned this pull request Nov 8, 2024
Merged
peterstadler added a commit that referenced this pull request Nov 8, 2024
@peterstadler
added missing Semicolon (#469)
101c328 
## Description, Context and related Issue
Missing semicolon lead to error in measure view. Bug was introduced in
#457

<!--- This project only accepts pull requests related to open issues.
Please link to the issue here: -->
Refs #468

## How Has This Been Tested?
With editionExample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterstadler peterstadler peterstadler approved these changes

@bwbohl bwbohl Awaiting requested review from bwbohl

Assignees
No one assigned
Labels
None yet
Projects
Edirom Development
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

SourceView: go to measure… function returns wrong measure
2 participants
@hizclick @peterstadler