Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all module imports relative #368 #456

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Make all module imports relative #368 #456

merged 2 commits into from
Oct 23, 2024

Conversation

hizclick
Copy link
Contributor

@hizclick hizclick commented Oct 18, 2024 •
edited
Loading

Description, Context and related Issue

Refs #

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

peterstadler
peterstadler approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Many thanks :)

@bwbohl bwbohl added this to the 1.0.0 milestone Oct 23, 2024
@bwbohl bwbohl merged commit 5e8d3b8 into develop Oct 23, 2024
3 checks passed
@bwbohl bwbohl deleted the Make-all-module-imports-relative-#368 branch October 23, 2024 08:01
@hizclick hizclick linked an issue Oct 24, 2024 that may be closed by this pull request
Make all module imports relative #368
Closed
Diginaut pushed a commit to korngold-werkausgabe/Edirom-Online_EWK-WA that referenced this pull request Dec 16, 2024
@hizclick
Make all module imports relative Edirom#368 (Edirom#456)
861ec2d 
* Make-all-module-imports-relative Resolving issue Edirom#368

* Make-all-module-imports-relative Resolving issue Edirom#368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbohl bwbohl bwbohl approved these changes

@peterstadler peterstadler peterstadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Edirom Development
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Make all module imports relative
3 participants
@hizclick @peterstadler @bwbohl