add XQuery test to check for missing entries in language files

[peterstadler]

Description, Context and related Issue

This PR introduces a new XQuery based check for missing entries in language files

Refs #154

How Has This Been Tested?

Checked locally by modifying language files and checking results of running ant check-language-files

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document.

[peterstadler]

I've also added the new check "check-language-files" to the Github actions:

1. The run https://github.com/Edirom/Edirom-Online/actions/runs/11352963364/job/31576942488 failed due to a missing entry in the German language file
2. After adding the missing entry the Github action passed: https://github.com/Edirom/Edirom-Online/actions/runs/11353084552/job/31577350564

[roewenstrunk]

When I run the test, I get an error because I don't have the right libraries for ant: [java] Could not find net.sf.saxon.Query. Make sure you have it in your classpath.
Would you like to write a minimal description in the wiki of how this type of tests work and what requirements must be met?

[peterstadler]

I have added some basic information regarding dependencies in the Readme:

Edirom-Online/README.md

Lines 104 to 110 in 3e57257

	For running the tests provided in the [ANT build file] we rely on `xmllint`
	and `SaxonHE`.
	On a Debian based Linux system these can be installed with `apt-get install
	libsaxonhe-java libxml2-utils`.
	If SaxonHE is not available from your classpath by default you might need to
	explicitly point ANT at it by providing the `-lib` parameter, e.g. `ant -lib
	/usr/share/java/ run-all-tests`.

[peterstadler]

pinging @bwbohl and @roewenstrunk for reviewing

[bwbohl]

Ok, I successfully tested the lang-test by doing the following:

1. Use bwbohl/sencha-cmd as described in the README.

2. Install missing dependecies for the tests

   apt-get update
   

   apt-get install libsaxonhe-java
   

3. from within '/app' run the test, referencing the JARs and the buildfile

ant -lib /usr/share/java/ -buildfile testing/ant-tests.xml check-language-files

This reported nothing and when changing the name of one entry it reported the original term missing in the modified file and the modified term in the other file. Everything as expected, very nice!

[bwbohl]

Just a short follow-up: Should we also check add/data/xslt/i18n?

[bwbohl]

Thanks for imrproving!
Lot’s of discrepancies surfaced this way. Probably we should fix. them before merging ;-)

[bwbohl]

Just trying to fix the files and realised maybe we should also cover duplicates in the error report. Currently this would be the result for a duplicate entry in one file:

<key missing="" available="en de">csl</key>

[peterstadler]

Regarding duplicates: Shall I add proper output for that case or is the current (undocumented) way of surfacing duplicates ok for now?

[bwbohl]

I’d prefer making it clean now, so e.g.

<key missing="" available="en de" duplicate="de">csl</key>

[peterstadler]

added explicit warning for duplicate keys. Output looks like:

<results>
   <key duplicates="de en">controller.window.Window_renderingView</key>
   <key missing="en" available="de">global_execute</key>
   <key duplicates="de">controller.window.Window_summaryView</key>
   <key missing="de" available="en">global_execue</key>
</results>

[bwbohl]

After retesting I have to report that it works fine for the files in locale but does not report duplicates in the new style when there are some in the ì18n` files.

Moreover if there˚s a duplicate in one of the locale files and another in the ì18nfiles only thelocale` gets reported.

[peterstadler]

Thank you very much @bwbohl for the thorough review!
In added your suggestions (great idea to run the tests in parallel!) and finally did some very explicit typing ;)

Works on my machine but it'd be great if you could have yet another (last) look.

[bwbohl]

Added some minor code linting.
Works like a charm, great implementation work, love it!