-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/279 start documents uri not found #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The getPreference
function has a second parameter lax
. You could use that parameter in the openStartDocuements
function. It will return null
if there is no data. Then check uris
for being null
. No ignoredKeys
in getPreferences
needed.
Thanks for the addition! I tried that with values true and 1 for parameter lax (see comment), and it did not work. Should it get another value? |
Ah, wait... I had a caching issue. Will try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me
Thanks @daniel-jettka & @roewenstrunk for fixing this ;-) |
* added exception to not throw error on empty key * changed find in array method * condition to only load links on start when provided * changed to use of parameter lax
Description, Context and related Issue
When key start_documents_uri is no provided in prefs file, then an error message was thrown to the logs, which can be seen as too verbose. Some conditions were introduced to prevent the error message for this key. Can be extended to more keys if desired.
Refs #279
How Has This Been Tested?
Built and deployed Edirom with EditionExample. No error on console anymore.
Types of changes
Checklist