-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] Set up CONTRIBUTING.md #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former content of this file (styleguide content) was moved to its own file STYLE-GUIDE.md with PR Edirom#404. Contribution guidelines were set up now. Refs Edirom#227
information regarding how to test the code before starting a pull request was added, the description was taken from the README.md. Refs Edirom#408
riedde
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @krHERO for the additions. I have just two small comments or suggestions.
thanks @riedde for reviewing. i like your updates :) Co-authored-by: Dennis Ried <[email protected]>
Merged
daniel-jettka
approved these changes
Aug 28, 2024
Diginaut
pushed a commit
to korngold-werkausgabe/Edirom-Online_EWK-WA
that referenced
this pull request
Dec 16, 2024
information regarding how to test the code before starting a pull request was added, the description was taken from the README.md. Refs Edirom#408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former content of this file (styleguide content) was moved to its own file STYLE-GUIDE.md with PR #404. Contribution guidelines were set up now from scratch. Some parts are inspired from the CONTRIBUTING.md of the music-encoding repository and adjusted, thanks for their great work!
Closes #227