Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr] Set up CONTRIBUTING.md #408

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

krHERO
Copy link
Member

@krHERO krHERO commented Aug 15, 2024

The former content of this file (styleguide content) was moved to its own file STYLE-GUIDE.md with PR #404. Contribution guidelines were set up now from scratch. Some parts are inspired from the CONTRIBUTING.md of the music-encoding repository and adjusted, thanks for their great work!

Closes #227

The former content of this file (styleguide content) was moved to its own file STYLE-GUIDE.md with PR Edirom#404. Contribution guidelines were set up now.

Refs Edirom#227
@krHERO krHERO added this to the 1.0.0 milestone Aug 15, 2024
information regarding how to test the code before starting a pull request was added, the description was taken from the README.md. 

Refs Edirom#408
Copy link
Contributor

@riedde riedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @krHERO for the additions. I have just two small comments or suggestions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
thanks @riedde for reviewing. i like your updates :)

Co-authored-by: Dennis Ried <[email protected]>
@krHERO krHERO mentioned this pull request Aug 19, 2024
@daniel-jettka daniel-jettka self-requested a review August 28, 2024 14:00
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@daniel-jettka daniel-jettka merged commit 1c7c244 into Edirom:develop Aug 28, 2024
1 check passed
@krHERO krHERO deleted the ftr-update_CONTRIBUTING branch November 13, 2024 20:18
Diginaut pushed a commit to korngold-werkausgabe/Edirom-Online_EWK-WA that referenced this pull request Dec 16, 2024
information regarding how to test the code before starting a pull request was added, the description was taken from the README.md. 

Refs Edirom#408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Set up contribution guidelines
3 participants