Ftr/358 grayout goto movement #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin W. Bohl <[email protected]>
Before this commit, Edirom Online assumed that an annotation would only be shown if it matched both category and priority filters; this was a problem for editions that would not use, e.g., priorities at all. Consequently, the priorities filter would be empty, and the annotation would always return false for that filter. After this commit, there is a value 'undefined' for visibleCategorie and visibleAnnotations, and the filter corresponding result for an annotation will be set to true if the corresponding visibleCategorie or visiblePriorities is 'undefined',
…element retrieval maybe fix later
…bleCategories variable
…e menu would be populated
6 tasks
Fix/annotations on page
…cuments Fix/339 facsimile view with tei documents
Signed-off-by: Benjamin W. Bohl <[email protected]>
riedde
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the go-to menu and partly fixes #358. The number of movements is checked, and the goto Movement and the movement combobox in the go-to measure menus are grayed-out if there is only one or fewer movements.