Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MEI version check in source:isSource function #363

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix MEI version check in source:isSource function #363

merged 2 commits into from
Feb 8, 2024

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Feb 7, 2024

  • makes the regEx match MEI 5.0 version numbers
  • makes the regex check more strict `^…&``
  • fixes and adds documentation of source:isSource

@bwbohl bwbohl requested a review from riedde February 7, 2024 20:55
@bwbohl bwbohl added this to the 1.0.0-beta.6 milestone Feb 7, 2024
riedde
riedde previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@riedde riedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great regex! Hopefully the MEI community doesn't change everything for version 6 so it doesn't get more complex ;-)

add/data/xqm/source.xqm Outdated Show resolved Hide resolved
@bwbohl bwbohl merged commit 44c48aa into develop Feb 8, 2024
1 check passed
@bwbohl bwbohl deleted the fix/mei-source-version-check branch February 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riedde riedde riedde left review comments

Assignees
No one assigned
Labels
None yet
Projects
Edirom Development
Status: Done
Milestone
1.0.0-beta.6
Development

Successfully merging this pull request may close these issues.
2 participants
@bwbohl @riedde