Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Annotation tooltip (layout) #354

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Feb 5, 2024

No description provided.

@bwbohl bwbohl marked this pull request as draft February 5, 2024 22:56
@bwbohl
Copy link
Member Author

bwbohl commented Feb 5, 2024

@riedde is this tested?
Generally I think wh should reactivate the metabox in the way you did and leave it to the edition to deactivate it via CSS or introduce something like an annotation-preview templating system. What do the @Edirom/edirom-online-developer s think?

@riedde
Copy link
Contributor

riedde commented Feb 7, 2024

@bwbohl Yes, this feature should be activated. I've tested it and noticed, that there is a problem on the layout and dimensions of the annot-tooltip. Maybe we can fix that also in this PR

@riedde
Copy link
Contributor

riedde commented Feb 7, 2024

Today's Dev-Meeting: I remembered that my intention was to fix the tooltip. But now I found out that I misinterpreted what the metabox is. @nikobeer and I will have a look at it.

@riedde riedde changed the title activate metabox and make it relative fix: Annotation tooltip (layout) Feb 7, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Feb 19, 2024

I think, this was in the wake of reactivating everything instead of simply commenting it out in the sourcecode.

@bwbohl bwbohl added this to the 1.0.0-beta.6 milestone Jun 25, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Jun 26, 2024

I think this should be easily reactivated. Some CSS necessary. It could be hidden via CSS if someone does not want it in their edition.
A future perspective would be to add some annotation tooltip layouts to choose from that are similar to the annotation layouts.

@bwbohl bwbohl changed the title fix: Annotation tooltip (layout) Fix: Annotation tooltip (layout) Jun 27, 2024
@riedde
Copy link
Contributor

riedde commented Jun 27, 2024

I'm not sure why I did this adjustment, but it seems to be a bigger issue. Maybe opening an Issue and closing this PR draft?

@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.0.0 Sep 5, 2024
@bwbohl
Copy link
Member Author

bwbohl commented Dec 18, 2024

Considering that reactivating the metaBox will pile up more additional work than we want for the upvomin 1.0.0 release, I'd opt for pushing this to 1.1.0, too. Any objections?

@krHERO krHERO modified the milestones: 1.0.0, 1.2.0 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants