Feature: Auto measure label handling

[riedde]

Better handling of Measure labels

• joining labels when multiple measures pointing to same zone (avoids labels like 1/9)
• also works with already joined labels (multiRests)
• introducing diacritical labels (supplied and del)

needs:

• code clean up
• introducing functions (avoid redundancy)

[bwbohl]

@riedde what’s the status of this draft, any chance to resolve conflicts and close TODOs in the near future?

[riedde]

@bwbohl conflicts resolved. I'll have a look at the TODOs

[bwbohl]

What’s an appropriate dataset for testing this?

[riedde]

@bwbohl e.g., https://klarinettenquintett.weber-gesamtausgabe.de/index.html?lang=de (Erstdruck 1)

[bwbohl]

Tested with the klarinettenquintett dataset:

• label seem correct but Concordance navigation fails ,e.g. On Baermann D+-st with the multirest in Allegro/Klarinette M.1–11 ff.

[bwbohl]

The multiRest at the start of the Allegro in D+-st is also missing "–11"

[bwbohl]

multiRest handling doesn’t seem to work properly with data-set klarinettenquintett

[peterstadler]

Yes, we can! In fact, the file https://github.com/Edirom/Edirom-Online/blob/develop/add/data/xql/getMeasuresOnPage.xql in current develop branch already outputs proper JSON. The change here is a step backwards.

[peterstadler]

please keep the array constructor (or force measure:getMeasuresOnPage#2 to return an array)

[riedde]

At 2ad0a2d
The round brackets are removed. The function returns a map. Why should there be an array?

[peterstadler]

measure:getMeasures#2 returns a sequence of maps. If the sequence is gt 1 this will automatically be serialized to a JSON array. If the sequence is 1 the return type will be a JSON object. If it's 0 the return type will be NULL.
This is quite annoying for the frontend so it's much nicer to always return an array.

[riedde]

@peterstadler Done at 01568d2 I don't have time today to work on this, so if necessary, please fix directly before tomorrow's release.

[peterstadler]

There are still issues with MEI multiRest.
Consider the XQuery

xquery version "3.1";

declare namespace mei="http://www.music-encoding.org/ns/mei";

import module namespace measure = "http://www.edirom.de/xquery/measure" at "xmldb:exist:///db/apps/Edirom-Online/data/xqm/measure.xqm";


doc("/db/apps/Edirom-Online/testing/XQSuite/testdata/multiMeasureRests.xml")/mei:mdiv//mei:measure[1] 
    => measure:getMeasureLabel()

which will properly output

<xhtml:span xmlns:xhtml="http://www.w3.org/1999/xhtml">
    <xhtml:span>107</xhtml:span>
</xhtml:span>

but will fail for mei:measure[2] (which features multiRests):

Edirom-Online/testing/XQSuite/testdata/multiMeasureRests.xml

Lines 64 to 74 in def111d

	<measure xml:id="x9cafb006-025b-4019-9430-936ab85a62db" right="rptend" n="108">
	<staff xml:id="x734d85be-0016-46cb-870f-c83832a5a9db" n="1">
	<layer xml:id="x329eefc9-112e-45be-8d11-6192be6b9eba" n="1">
	<multiRest xml:id="xe9ace48e-8c8f-4e09-b148-669c9c622787" num="2"/>
	</layer>
	</staff>
	<staff xml:id="x103f0765-102b-45ba-935b-92991d7eb77f" n="2">
	<layer xml:id="x6e1af6eb-b22a-47e5-b62a-c77da263eb7d" n="1">
	<multiRest xml:id="x5b945b6f-ae28-44c3-b972-cd7e82453eda" num="2"/>
	</layer>
	</staff>

UPDATE: I just added a test for measure:getMeasureLabel#1 in 4d745b9

[peterstadler]

I tried to update the code but there's still a test failing for measure:getMeasureLabel#1 at

Edirom-Online/add/data/xqm/measure.xqm

Line 90 in b45c7b5

<xhtml:span>{$measureLabel || '–' || (number($measureLabel) + number($measure//mei:multiRest/@num) - 1)}</xhtml:span>

because there can be multiple <mei:multiRest> (in multiple layers) in an <mei:measure>.

[krHERO]

at the community meeting 2024-12-18 we agreed to move this PR to next release.
but extract parts from it and solve with #302 for v1.0.0 @feuerbart