Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: reintroduce iframe view #292

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

riedde
Copy link
Contributor

@riedde riedde commented Nov 27, 2022

While scanning the code I found some fragments of an iframe view. This PR is a contribution to reintroduce it.

@riedde riedde added this to the 1.0.0 milestone Nov 27, 2022
@riedde riedde self-assigned this Nov 27, 2022
@riedde riedde modified the milestones: 1.0.0, 1.0.0-beta.6 Dec 14, 2022
@bwbohl
Copy link
Member

bwbohl commented Feb 5, 2024

@riedde, what’s the status of this draft?
@Edirom/edirom-online-developer is there a need for an iFrameView – showing external resources might be a useful feature.

@riedde
Copy link
Contributor Author

riedde commented Feb 7, 2024

I'm not sure about my intention I had on this PR. Maybe to remodel a feature that has been lost at some day. Maybe I also tried to view the content of another eXist-App in an Edirom window (as the RWA did years ago).

@DennisFriedl
Copy link
Member

Might be usefull in some cases. Was it removed in the past?

@riedde
Copy link
Contributor Author

riedde commented Feb 7, 2024

Maybe deactivated or lost somehow. But not fully deleted, fragments are still there. So I think it wasn't planned to cut it out.

@nikobeer
Copy link
Member

nikobeer commented Feb 7, 2024

It should still work, i think. We still use it. For example here, when you click on „Textvergleich“ in the navigator: https://www.reger-werkausgabe.de/edition.html?workID=rwa_work_00036. It will open an object window containing an iFrame that is loading our text comparison tool.

Side note: Edirom-Online within RWA Online is provided within an iFrame. So: RWA Online -> iFrame Edirom-Online -> iFrame text comparison.

@bwbohl bwbohl modified the milestones: 1.0.0-beta.6, 1.0.0 Sep 5, 2024
Copy link
Member

@roewenstrunk roewenstrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iFrame view was used in several projects. So +1 for reactivating.
The SingleWindowController.js expects the views type to be iFrameView (

case 'iFrameView': return 'EdiromOnline.view.window.iFrameView';
). You used html_iFrameView. Does this work? Have you testet?

add/data/xql/getLinkTarget.xql Outdated Show resolved Hide resolved
add/data/xql/getLinkTarget.xql Outdated Show resolved Hide resolved
@riedde riedde force-pushed the ftr/reintroduce-iframe-view branch 2 times, most recently from f135780 to cc4fe8a Compare November 7, 2024 13:17
@riedde
Copy link
Contributor Author

riedde commented Nov 13, 2024

@roewenstrunk Do we have progress on this? If yes, could you push the changes we have done at our meeting?

@roewenstrunk roewenstrunk marked this pull request as ready for review December 2, 2024 09:08
@roewenstrunk roewenstrunk self-requested a review December 2, 2024 09:08
@krHERO krHERO merged commit 98234c5 into develop Dec 2, 2024
4 checks passed
@krHERO krHERO deleted the ftr/reintroduce-iframe-view branch December 2, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants