-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: reintroduce iframe view #292
Conversation
@riedde, what’s the status of this draft? |
I'm not sure about my intention I had on this PR. Maybe to remodel a feature that has been lost at some day. Maybe I also tried to view the content of another eXist-App in an Edirom window (as the RWA did years ago). |
Might be usefull in some cases. Was it removed in the past? |
Maybe deactivated or lost somehow. But not fully deleted, fragments are still there. So I think it wasn't planned to cut it out. |
It should still work, i think. We still use it. For example here, when you click on „Textvergleich“ in the navigator: https://www.reger-werkausgabe.de/edition.html?workID=rwa_work_00036. It will open an object window containing an iFrame that is loading our text comparison tool. Side note: Edirom-Online within RWA Online is provided within an iFrame. So: RWA Online -> iFrame Edirom-Online -> iFrame text comparison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iFrame view was used in several projects. So +1 for reactivating.
The SingleWindowController
.js expects the views type to be iFrameView
(
case 'iFrameView': return 'EdiromOnline.view.window.iFrameView'; |
html_iFrameView
. Does this work? Have you testet?
f135780
to
cc4fe8a
Compare
@roewenstrunk Do we have progress on this? If yes, could you push the changes we have done at our meeting? |
While scanning the code I found some fragments of an iframe view. This PR is a contribution to reintroduce it.